From: Luis Carlos Cobo <luisca@cozybit.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: partially fix skb->cb use
Date: Tue, 29 Jul 2008 13:23:24 +0200 [thread overview]
Message-ID: <1217330604.6379.12.camel@localhost> (raw)
In-Reply-To: <1217323927.10489.9.camel@johannes.berg>
On Tue, 2008-07-29 at 11:32 +0200, Johannes Berg wrote:
> This patch fixes mac80211 to not use the skb->cb over the queue step
> from virtual interfaces to the master. The patch also, for now,
> disables aggregation because that would still require requeuing,
> will fix that in a separate patch. There are two other places (software
> requeue and powersaving stations) where requeue can happen, but that is
> not currently used by any drivers/not possible to use respectively.
On net/mac80211/rx.c:ieee80211_data_to_8023() cb is used for mesh frames
to save the original mesh header. Then if the frame has to be forwarded,
the frame is queued on the virtual interface and
net/mac80211/tx.c:ieee80211_subif_start_xmit() expects the mesh header
to remain in the cb if the frame is not originally from the local host.
It's a different step from the one you mention, but as I understand it
it may suffer the same problem right?
--
Luis Carlos Cobo Rus GnuPG ID: 44019B60
cozybit Inc.
next prev parent reply other threads:[~2008-07-29 11:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 9:32 [PATCH] mac80211: partially fix skb->cb use Johannes Berg
2008-07-29 10:13 ` David Miller
2008-07-29 10:48 ` Tomas Winkler
2008-07-29 10:49 ` Johannes Berg
2008-07-29 11:01 ` Tomas Winkler
2008-07-29 11:23 ` Luis Carlos Cobo [this message]
2008-07-29 11:24 ` Johannes Berg
2008-07-29 11:42 ` Luis Carlos Cobo
2008-07-29 11:51 ` Johannes Berg
2008-07-29 12:03 ` Luis Carlos Cobo
2008-07-29 12:07 ` Johannes Berg
2008-07-29 15:58 ` Luis Carlos Cobo
2008-07-30 7:17 ` Johannes Berg
2008-07-29 14:47 ` Larry Finger
2008-07-29 14:50 ` Johannes Berg
2008-07-29 20:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217330604.6379.12.camel@localhost \
--to=luisca@cozybit.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.