From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
hpa <hpa@zytor.com>, Eric Biederman <ebiederm@xmission.com>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Mike Travis <travis@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Yinghai Lu <yhlu.kernel@gmail.com>
Subject: [PATCH 01/16] x86: 64bit support more than 256 irq
Date: Fri, 1 Aug 2008 02:37:29 -0700 [thread overview]
Message-ID: <1217583464-28494-2-git-send-email-yhlu.kernel@gmail.com> (raw)
In-Reply-To: <1217583464-28494-1-git-send-email-yhlu.kernel@gmail.com>
Dhaval Giani got:
kernel BUG at arch/x86/kernel/io_apic_64.c:357!
invalid opcode: 0000 [1] SMP
CPU 24
...
his system (x3950) has 8 ioapic, irq > 256
caused by
commit 9b7dc567d03d74a1fbae84e88949b6a60d922d82
Author: Thomas Gleixner <tglx@linutronix.de>
Date: Fri May 2 20:10:09 2008 +0200
x86: unify interrupt vector defines
The interrupt vector defines are copied 4 times around with minimal
differences. Move them all into asm-x86/irq_vectors.h
because 64bit allow same vector for different cpu to serve different irq
need to create that array dynamically later
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Tested-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
---
include/asm-x86/irq_vectors.h | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
Index: linux-2.6/include/asm-x86/irq_vectors.h
===================================================================
--- linux-2.6.orig/include/asm-x86/irq_vectors.h
+++ linux-2.6/include/asm-x86/irq_vectors.h
@@ -113,28 +113,26 @@
# if defined(CONFIG_X86_IO_APIC) || defined(CONFIG_PARAVIRT) || defined(CONFIG_X86_VISWS)
+#ifdef CONFIG_X86_64
+# define NR_IRQS (32 * NR_CPUS + 224)
+#else
# define NR_IRQS 224
-
-# if (224 >= 32 * NR_CPUS)
-# define NR_IRQ_VECTORS NR_IRQS
-# else
-# define NR_IRQ_VECTORS (32 * NR_CPUS)
-# endif
+#endif
# else /* IO_APIC || PARAVIRT */
# define NR_IRQS 16
-# define NR_IRQ_VECTORS NR_IRQS
# endif
#else /* !VISWS && !VOYAGER */
# define NR_IRQS 224
-# define NR_IRQ_VECTORS NR_IRQS
#endif /* VISWS */
+#define NR_IRQ_VECTORS NR_IRQS
+
/* Voyager specific defines */
/* These define the CPIs we use in linux */
#define VIC_CPI_LEVEL0 0
next prev parent reply other threads:[~2008-08-01 9:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 9:37 [PATCH 00/16] dyn_array and nr_irqs support v2 Yinghai Lu
2008-08-01 9:37 ` Yinghai Lu [this message]
2008-08-01 9:37 ` [PATCH 02/16] x86: introduce nr_irqs for 64bit v3 Yinghai Lu
2008-08-01 9:37 ` [PATCH 03/16] add dyn_array support Yinghai Lu
2008-08-01 9:37 ` [PATCH 04/16] make irq_timer_state to use dyn_array Yinghai Lu
2008-08-01 9:37 ` [PATCH 05/16] make irq2_iommu " Yinghai Lu
2008-08-01 9:37 ` [PATCH 06/16] make irq_desc " Yinghai Lu
2008-08-01 9:37 ` [PATCH 07/16] x86: make 64bit support dyn_array Yinghai Lu
2008-08-01 9:37 ` [PATCH 08/16] serial: change remove NR_IRQS in 8250.c v2 Yinghai Lu
2008-08-01 9:37 ` [PATCH 09/16] add per_cpu_dyn_array support Yinghai Lu
2008-08-01 9:37 ` [PATCH 10/16] irq: make irqs in kernel stat use per_cpu_dyn_array Yinghai Lu
2008-08-01 9:37 ` [PATCH 11/16] x86 remove irq_vectors_limit.h Yinghai Lu
2008-08-01 9:37 ` [PATCH 12/16] x86: make 32bit use dyn_array Yinghai Lu
2008-08-01 9:37 ` [PATCH 13/16] add per_cpu_dyn_array for arch percpu support Yinghai Lu
2008-08-01 9:37 ` [PATCH 14/16] x86: get mp_irqs from madt Yinghai Lu
2008-08-01 9:37 ` [PATCH 15/16] x86: make 32bit more like with io_apic/dyn_array to 64 bit Yinghai Lu
2008-08-01 9:37 ` [PATCH 16/16] x86: alloc dyn_array all alltogether Yinghai Lu
2008-08-01 20:46 ` [PATCH 00/16] dyn_array and nr_irqs support v2 Eric W. Biederman
2008-08-01 21:30 ` Yinghai Lu
2008-08-01 21:57 ` Yinghai Lu
2008-08-01 22:45 ` Eric W. Biederman
2008-08-01 22:10 ` Yinghai Lu
2008-08-01 22:38 ` Eric W. Biederman
2008-08-02 1:09 ` Yinghai Lu
2008-08-02 1:36 ` H. Peter Anvin
2008-08-02 1:41 ` Eric W. Biederman
2008-08-02 2:01 ` Yinghai Lu
2008-08-02 2:03 ` H. Peter Anvin
2008-08-02 2:39 ` Eric W. Biederman
2008-08-02 3:28 ` H. Peter Anvin
2008-08-02 4:42 ` Eric W. Biederman
2008-08-02 15:41 ` H. Peter Anvin
2008-08-02 20:20 ` Eric W. Biederman
2008-08-04 12:57 ` Mike Travis
2008-08-05 2:38 ` H. Peter Anvin
2008-08-05 3:40 ` Eric W. Biederman
2008-08-05 3:48 ` H. Peter Anvin
2008-08-01 21:47 ` Mike Travis
2008-08-02 2:58 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217583464-28494-2-git-send-email-yhlu.kernel@gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.