From: Dmitry Adamushko <dmitry.adamushko@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Tigran Aivazian <tigran@aivazian.fsnet.co.uk>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Oruba <peter.oruba@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Max Krasnyansky <maxk@qualcomm.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
LKML <linux-kernel@vger.kernel.org>
Subject: [rfc-patch, bugfix] x86-microcode
Date: Sun, 03 Aug 2008 17:42:15 +0200 [thread overview]
Message-ID: <1217778135.4912.40.camel@earth> (raw)
Hi,
[ consider it a pre-release and RFC... I'm a bit in hurry now and just send what I have got by this moment.
Although, I expect it to be workable ]
this change is supposed to fix bug#11197 (note, its name "Oops in microcode sysfs registration" is misleading)
The problem description can be found here:
http://www.ussg.iu.edu/hypermail/linux/kernel/0807.3/3791.html
or
http://lkml.org/lkml/2008/7/24/260
perhaps it does look quite bulky for -rc, although it's mainly move-redesign-some-bits of the code and
I tried to preserve the original logic (even if it looked like a possible optimizations might had been applied)
as much as possible.
The basic idea is that we introduce another mechanism to run ucode-updates on a target cpu
and replace set_cpus_allowed_ptr() in (1) cpu-hotplug events and (2) module load.
[1/2] x86-microcode: generic updates
Basically, it introduces microcode_update_cpu() which can be run either from start_secondary()
(perhaps via a function pointer) or scheduled via keventd ([2/2]) and reworks the logic of cpu-hotplug events.
[2/2] x86-microcode: do updates via workqueue
More testing is necessary. I tested without ucode-package (so only generic machinery) and for
- load/unload module;
- cpu-hotplug (so it doesn't give an oops anymore)
hm, suspend/resume seems to be broken even without the 'microcode' module (will check the date of my previous kernel).
--Dmitry
next reply other threads:[~2008-08-03 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-03 15:42 Dmitry Adamushko [this message]
2008-08-04 19:31 ` [rfc-patch, bugfix] x86-microcode Max Krasnyansky
2008-08-04 20:01 ` Dmitry Adamushko
2008-08-04 21:32 ` Max Krasnyansky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217778135.4912.40.camel@earth \
--to=dmitry.adamushko@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=mingo@elte.hu \
--cc=peter.oruba@amd.com \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=tigran@aivazian.fsnet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.