All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Yi <yi.zhu@intel.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: ipw3945-devel@lists.sourceforge.net, linux-wireless@vger.kernel.org
Subject: Re: [IWL3945]Fix statistics in monitor mode
Date: Mon, 04 Aug 2008 11:32:17 +0800	[thread overview]
Message-ID: <1217820737.3107.15.camel@debian.sh.intel.com> (raw)
In-Reply-To: <4892E14A.4000203@gmail.com>

On Fri, 2008-08-01 at 13:11 +0300, Maxim Levitsky wrote:
> I guess it is time for me to add my .02 cents to iwlwifi driver.
> Recently I reported a bug about crazy statistics (> 100 quality for 
> example) when turning on the monitor interface (this bug actually is 
> triggered when card is put in monitor mode, thus shows up when promisc
> mode enabled as well)
> 
> It turns out that iwl3945_rx_reply_rx wasn't filling in the statistics
> when running in monitor on, instead a garbage was passed.

Good catch. I'd suggest change 3945 the same way as 4965. That is, move
the iwl_pass_packet_to_mac80211() for MNTR before setting
priv->last_beacon_time, et al. We don't need to update these fields in
monitor mode anyway.

Thanks,
-yi


  reply	other threads:[~2008-08-04  3:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-01 10:11 [IWL3945]Fix statistics in monitor mode Maxim Levitsky
2008-08-04  3:32 ` Zhu Yi [this message]
2008-08-05  1:47   ` [ipw3945-devel] " Junty Mesmon
2008-08-05  3:36     ` Zhu Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1217820737.3107.15.camel@debian.sh.intel.com \
    --to=yi.zhu@intel.com \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.