All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	Aneesh Kumar KV <aneesh.kumar@linux.vnet.ibm.com>,
	Balbir Singh <balbir@in.ibm.com>
Subject: Re: VolanoMark regression with 2.6.27-rc1
Date: Mon, 04 Aug 2008 08:54:26 +0200	[thread overview]
Message-ID: <1217832866.9016.45.camel@twins> (raw)
In-Reply-To: <20080804055339.GB5444@linux.vnet.ibm.com>

On Mon, 2008-08-04 at 11:23 +0530, Dhaval Giani wrote:

> Peter, vatsa, any ideas?

---
Subject: sched: scale sysctl_sched_shares_ratelimit with nr_cpus

David reported that his Niagra spend a little too much time in
tg_shares_up(), which considering he has a large cpu count makes sense.

So scale the ratelimit value with the number of cpus like we do for
other controls as well.

Reported-by: David Miller <davem@davemloft.net>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
diff --git a/kernel/sched.c b/kernel/sched.c
index 9a76e92..7eddaea 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -809,9 +809,9 @@ const_debug unsigned int sysctl_sched_nr_migrate = 32;
 
 /*
  * ratelimit for updating the group shares.
- * default: 0.5ms
+ * default: 0.25ms
  */
-const_debug unsigned int sysctl_sched_shares_ratelimit = 500000;
+const_debug unsigned int sysctl_sched_shares_ratelimit = 250000;
 
 /*
  * period over which we measure -rt task cpu usage in us.
@@ -5732,6 +5732,8 @@ static inline void sched_init_granularity(void)
 		sysctl_sched_latency = limit;
 
 	sysctl_sched_wakeup_granularity *= factor;
+
+	sysctl_sched_shares_ratelimit *= factor;
 }
 
 #ifdef CONFIG_SMP



  parent reply	other threads:[~2008-08-04  6:54 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31  3:20 VolanoMark regression with 2.6.27-rc1 Zhang, Yanmin
2008-07-31  7:31 ` Zhang, Yanmin
2008-07-31  7:39   ` Peter Zijlstra
2008-07-31  7:49     ` Zhang, Yanmin
2008-08-01  0:39       ` Zhang, Yanmin
2008-08-01  2:35         ` Miao Xie
2008-08-01  3:08           ` Zhang, Yanmin
2008-08-01  5:14         ` Dhaval Giani
2008-08-04  5:04           ` Zhang, Yanmin
2008-08-04  5:22             ` Dhaval Giani
2008-08-04  5:37               ` Zhang, Yanmin
2008-08-04  5:53                 ` Dhaval Giani
2008-08-04  6:26                   ` Peter Zijlstra
2008-08-04  6:26                   ` Peter Zijlstra
2008-08-04  7:05                     ` Dhaval Giani
2008-08-04  7:12                       ` Peter Zijlstra
2030-08-06  3:26                         ` Zhang, Yanmin
2008-08-08  7:30                           ` Peter Zijlstra
     [not found]                             ` <20080811185008.GA29291@linux.vnet.ibm.com>
     [not found]                               ` <1912726331.25608.235.camel@ymzhang>
     [not found]                                 ` <20080817115035.GA32223@linux.vnet.ibm.com>
     [not found]                                   ` <20080818052155.GA5063@linux.vnet.ibm.com>
2008-08-20  7:24                                     ` Zhang, Yanmin
2008-08-20  7:41                                       ` Peter Zijlstra
2008-08-20 10:51                                         ` Ingo Molnar
2008-08-20 13:32                                           ` Peter Zijlstra
2008-08-20 13:47                                             ` Ingo Molnar
2008-08-21  2:25                                               ` Zhang, Yanmin
2008-08-21  6:16                                                 ` Ingo Molnar
2008-08-21  6:48                                                   ` Zhang, Yanmin
2008-08-29  3:35                                                     ` Zhang, Yanmin
2008-08-29  3:38                                                       ` Zhang, Yanmin
2008-08-20 14:32                                             ` adobriyan
2008-08-20 14:33                                               ` Peter Zijlstra
2008-08-20 15:10                                                 ` Nick Piggin
2008-08-20 15:15                                                   ` Peter Zijlstra
2008-08-20 16:29                                                   ` Ray Lee
2008-08-20 16:51                                                     ` Peter Zijlstra
2008-08-20 17:21                                                     ` Peter Zijlstra
2008-08-20 17:55                                                       ` Nick Piggin
2008-08-20 18:15                                                         ` Ray Lee
2008-08-20 20:30                                                           ` Peter Zijlstra
2008-08-20 20:56                                                             ` Peter Zijlstra
2008-08-21  6:11                                                               ` Nick Piggin
2008-08-21  8:17                                                                 ` Peter Zijlstra
2008-08-21  6:15                                                               ` Ingo Molnar
2008-08-20 20:58                                                             ` Ray Lee
2008-08-20 21:04                                                               ` Peter Zijlstra
2008-08-21  6:12                                                       ` Ingo Molnar
2030-08-13  8:50                             ` Zhang, Yanmin
2008-08-04  6:54                   ` Peter Zijlstra [this message]
2008-08-15 15:37                     ` Ingo Molnar
2008-08-01 12:25 ` Hugh Dickins
2008-08-04  0:54   ` Zhang, Yanmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1217832866.9016.45.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=balbir@in.ibm.com \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=vatsa@linux.vnet.ibm.com \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.