From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KQCOq-0003Ou-5Y for mharc-grub-devel@gnu.org; Mon, 04 Aug 2008 22:35:48 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQCOo-0003MU-M2 for grub-devel@gnu.org; Mon, 04 Aug 2008 22:35:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQCOm-0003Ji-K3 for grub-devel@gnu.org; Mon, 04 Aug 2008 22:35:46 -0400 Received: from [199.232.76.173] (port=37755 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQCOm-0003J2-3m for grub-devel@gnu.org; Mon, 04 Aug 2008 22:35:44 -0400 Received: from an-out-0708.google.com ([209.85.132.247]:43770) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQCOl-0002QU-As for grub-devel@gnu.org; Mon, 04 Aug 2008 22:35:44 -0400 Received: by an-out-0708.google.com with SMTP id c38so443614ana.84 for ; Mon, 04 Aug 2008 19:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer; bh=lfhR6IIYnoQEhDp3UYPxLckQAI3W25dzPFe+6KJegKc=; b=DJ5hzJa6B5j7eyiNQ9SUJDDHVN0hg19lLw650SGXsbZ7fGLJyBVmQmn1LxaeARp+Qr HJsYkwVYmwdjDn9kqfxGKBrXLCQ+XC4L8A+IqdiMWNg/5T9+Lgle0KQFJJYnUW4g/7A3 6Au4F26Yxzh3PO3WpdZ4j4jvrUFRC/tM5UZKI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer; b=XXuPQ/Ja2jY27w+qJF8jGfYZAXJaqDL0TbuRzqzcu6eikgeuD5PGskM3jh0XvdZjHT F06sz8q6XENI/kMi0o9i4uSD44OJD6YzKmAMs/4ZTPvQKrm7pBvFbXgCw9KPTSAnH5VG 5mvg/icmaKAb6zQoVx8hy7/GFjPSXig6UlnA8= Received: by 10.100.144.11 with SMTP id r11mr704683and.52.1217903740851; Mon, 04 Aug 2008 19:35:40 -0700 (PDT) Received: from ?192.168.1.100? ( [213.37.137.93]) by mx.google.com with ESMTPS id h18sm21889213wxd.9.2008.08.04.19.35.38 (version=SSLv3 cipher=RC4-MD5); Mon, 04 Aug 2008 19:35:40 -0700 (PDT) From: Javier =?ISO-8859-1?Q?Mart=EDn?= To: The development of GRUB 2 In-Reply-To: <4897A3DC.4050705@isaac.cedarswampstudios.org> References: <1215137528.26019.58.camel@localhost> <87bq0sibu0.fsf@xs4all.nl> <1216601741.8334.122.camel@localhost> <877ib1khe9.fsf@xs4all.nl> <1217806150.9634.24.camel@localhost> <87iqug33m9.fsf@xs4all.nl> <1217891426.15145.38.camel@localhost> <4897A3DC.4050705@isaac.cedarswampstudios.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-9ehhK7CSYudqTAvs3mJQ" Date: Tue, 05 Aug 2008 04:38:00 +0200 Message-Id: <1217903880.5754.14.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: [PATCH] Drivemap module X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2008 02:35:47 -0000 --=-9ehhK7CSYudqTAvs3mJQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi there and thanks for playing The Game! El lun, 04-08-2008 a las 20:50 -0400, Isaac Dupree escribi=C3=B3: > Javier Mart=C3=ADn wrote: > > You understand my concern, but seemingly do not understand that in orde= r > > to conform to the Holy Coding Style you are asking me to write code tha= t > > can become buggy (and with a very hard to trace bug) with a simple > > deltion! (point: did you notice that last word _without_ a spelling > > checker? Now try to do so in a multithousand-line program). >=20 > well, maybe a bit off topic. > But I can't imagine how, after code is written, I could=20 > accidentally delete an "=3D" character even when editing it.=20 > I prefer the (to me) intuitive meaning of (variable =3D=3D=20 > value) in my own code. That particular problem has never=20 > bitten me. Although, in C++ coding style, a lot more local=20 > variables are "const" and therefore the error could be=20 > caught by the compiler anyway. It seems like an odd=20 > paranoia to choose. Say, take "uint32_t". It's only a=20 > one-character deletion to become int32_t and then there is=20 > subtle breakage. "htons" and many other functions with=20 > similar names and suffixes. Etc.? It's half C language and=20 > culture, and half inevitable in programming, IMHO. Sigh... Maybe I'm just a bit paranoid because I have been bitten by similar problems (not in "if"s, but mainly in loop condition checks) and they were painstakingly difficult to hunt down even in a good IDE like Netbeans: I sometimes considered the possibility of my computer having lost all sense of logic because I saw it singlestep into the "wrong" branch until I noticed the =3D instead of =3D=3D. True, the possibilities o= f causing such a change are very low. >=20 > point[2]: I half did notice the typo (only "half" because=20 > I've trained myself not to be too distracted by people's=20 > spelling), and I'm generally more precise when looking at=20 > code (maybe). ;-) So I thought, but even my own code dodges me at times, not to speak of others' code... >=20 > Anyway, since "they" are more likely to maintain the code in=20 > the long run than you, in general, the question is whether=20 > the code is more likely to become buggy by their hacking on=20 > it, if it follows project coding style or someone else's=20 > (your) "safer" coding style. Likely it's safer if using a=20 > consistent programming style. Although I personally don't=20 > see that it's very helpful to have a style that makes things=20 > down to the order of "=3D=3D" arguments be consistent within the=20 > project; haphazard only slows reading the tiniest bit, and I=20 > don't think it makes a different what order the arguments are... =EF=BB=BF Hmm... I was partially expecting a flamefest to start. Pity ^^ Well, let's spill a little napalm: the GNU style bracing is extremely silly!! Why the hell are the "if" and "else" blocks indented differently in this example? if (condition) return 0; else { return -1; } Nah, I'm not really bringing that issue, I was just joking, and in fact I'm reconsidering my objections to the operator=3D=3D arguments order rule, even though I still consider my style safer and more sensible. If someone else wants to express their opinion on that issue, do it fast before I completely submit to Master Marco's will :D Habbit --=-9ehhK7CSYudqTAvs3mJQ Content-Type: application/pgp-signature; name=signature.asc Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQIVAwUASJe9CKSl+Fbdeo72AQLeLBAAoAVwidaPYQ3qanMeJDwX65XBPMQ/2aCu V/b09D4Dse8hbbOpnpoalZSMau88iO+V9/XFh6jc825WBUaOjVbpKXGh7zGkCnuV Al7p12bN6ulsPTrUSpwwdkiT4VGgfl8x/ktjCVp3LaD1/qbgokAQ3e52ofpydgFN zJXKLtNQT9AKwHx9r7nxNLWqgSkt5XTiSxVCSlpX4CT7kbPp09bmdScF2cJKBWZ4 hjgKvfy0bVVArXlSu+OlfoSWfNozpxeDKGHBPa/pckTlvID5m/Rth6s6cyHkGZ6K Xc8oE1k+/ID3dtE/imcWCFtcR7NbyvOJeOv9AAeHCWQYVn8sptX3mb0apTY2LYM8 nxfIs/OEyUzpEYdn1sjKJRvGU3nMtOwWCu3WHpfpP3Kzwn53Zvv63/HXkv1RkbE9 8H1oCBdWefTYyHG6YIS+HGXlE8D4ennnX0QDdKAjWysabk18BR9oUhe2IR6kihhS EyN6H18I4KjmDVnOtCjQxpBCpcXHrePwPjyBgYch/KQ2k3NkC44QFhRfstiV28Po 8qLlNgFRExlf2oRq/Au9B9Z8u3zuoZZAHhJnZP4JlD05L1dd9b0OtJwVAOIXafm5 vK4btIZ6v1VgEmr370qxNpLnMEIy5M79rVCIe+FOixpLpqBUAvE3ZTX3MKNMRzes G6y4TsxiPKs= =oRIv -----END PGP SIGNATURE----- --=-9ehhK7CSYudqTAvs3mJQ--