On Tue, 2008-08-05 at 18:48 +0200, Segher Boessenkool wrote: > > So when we receive a spurious irq, EOI it, and then mask it. > > What happens when a new IRQ arrives on the interrupt controller > between these EOI and mask calls? Should you instead first mask > it, and only then EOI it? Or doesn't that work on XICS? Yeah right, in which case we'd have not EOI'ed that one and we're back at square one. It seems to work with a mask then EOI, so unless Milton says otherwise I'll do it that way - new patch coming. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person