From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KQjEZ-0003ll-Qf for mharc-grub-devel@gnu.org; Wed, 06 Aug 2008 09:39:23 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQjEX-0003ii-Du for grub-devel@gnu.org; Wed, 06 Aug 2008 09:39:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQjEU-0003e2-9i for grub-devel@gnu.org; Wed, 06 Aug 2008 09:39:20 -0400 Received: from [199.232.76.173] (port=37292 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQjEU-0003dk-3V for grub-devel@gnu.org; Wed, 06 Aug 2008 09:39:18 -0400 Received: from c60.cesmail.net ([216.154.195.49]:27374) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KQjET-0004AI-NT for grub-devel@gnu.org; Wed, 06 Aug 2008 09:39:17 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 06 Aug 2008 09:39:16 -0400 Received: from [192.168.1.225] (pool-71-185-138-248.phlapa.east.verizon.net [71.185.138.248]) by relay.cesmail.net (Postfix) with ESMTP id 4F995618F22 for ; Wed, 6 Aug 2008 09:39:16 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 Content-Type: text/plain Date: Wed, 06 Aug 2008 09:39:02 -0400 Message-Id: <1218029942.27785.3.camel@ct> Mime-Version: 1.0 X-Mailer: Evolution 2.23.4 (2.23.4-3.fc10) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: [PATCH] Warning fixes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Aug 2008 13:39:21 -0000 Hello! I've fixed the trivial stuff, but this may require comments. I'll be mostly offline for the next 3 weeks, so if it's OK, please apply it for me. ChangeLog: * disk/ata.c (grub_ata_pciinit): Mark pciid unused. * commands/i386/pc/pxecmd.c (grub_cmd_pxe): Mark argc and args unused. * include/grub/i386/pc/pxe.h (grub_pxenv_tftp_open): Use char instead of grub_uint8_t for strings. (grub_pxenv_tftp_get_fsize): Likewise. Index: disk/ata.c =================================================================== --- disk/ata.c (revision 1784) +++ disk/ata.c (working copy) @@ -429,7 +429,8 @@ } static int -grub_ata_pciinit (int bus, int device, int func, grub_pci_id_t pciid) +grub_ata_pciinit (int bus, int device, int func, + grub_pci_id_t pciid __attribute__ ((unused))) { static int compat_use[2] = { 0 }; grub_pci_address_t addr; Index: include/grub/i386/pc/pxe.h =================================================================== --- include/grub/i386/pc/pxe.h (revision 1784) +++ include/grub/i386/pc/pxe.h (working copy) @@ -236,7 +236,7 @@ grub_uint16_t status; grub_uint32_t server_ip; grub_uint32_t gateway_ip; - grub_uint8_t filename[128]; + char filename[128]; grub_uint16_t tftp_port; grub_uint16_t packet_size; } __attribute__ ((packed)); @@ -259,7 +259,7 @@ grub_uint16_t status; grub_uint32_t server_ip; grub_uint32_t gateway_ip; - grub_uint8_t filename[128]; + char filename[128]; grub_uint32_t file_size; } __attribute__ ((packed)); Index: commands/i386/pc/pxecmd.c =================================================================== --- commands/i386/pc/pxecmd.c (revision 1784) +++ commands/i386/pc/pxecmd.c (working copy) @@ -46,7 +46,9 @@ } static grub_err_t -grub_cmd_pxe (struct grub_arg_list *state, int argc, char **args) +grub_cmd_pxe (struct grub_arg_list *state, + int argc __attribute__ ((unused)), + char **args __attribute__ ((unused))) { if (! grub_pxe_pxenv) return grub_error (GRUB_ERR_FILE_NOT_FOUND, "no pxe environment"); -- Regards, Pavel Roskin