From: Michael Ellerman <michael@ellerman.id.au>
To: Simon Horman <horms@verge.net.au>
Cc: Matthew Wilcox <matthew@wil.cx>,
Sven Wegener <sven.wegener@stealer.net>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [patch] PCI: check the return value of device_create_bin_file() in pci_create_bus()
Date: Thu, 07 Aug 2008 10:30:26 +1000 [thread overview]
Message-ID: <1218069026.7900.0.camel@localhost> (raw)
In-Reply-To: <20080806233018.GG10636@verge.net.au>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On Thu, 2008-08-07 at 09:30 +1000, Simon Horman wrote:
> Check the return value of device_create_bin_file in pci_create_bus and
> unwind if necessary. Don't propagate error to caller, as failure to create
> these files shouldn't prevent PCI from being initialised.
>
> Cc: Sven Wegener <sven.wegener@stealer.net>
> Cc: Michael Ellerman <michael@ellerman.id.au>
> Cc: Matthew Wilcox <matthew@wil.cx>
> Signed-off-by: Simon Horman <horms@verge.net.au>
I hate to prolong the pain, but wasn't the plan to print a big fat
warning so that it's clear the system is not 100% happy.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-08-07 0:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 10:16 [patch] PCI: check the return value of device_create_bin_file() in pci_create_bus() Simon Horman
2008-08-05 10:33 ` Michael Ellerman
2008-08-05 10:39 ` Sven Wegener
2008-08-05 11:00 ` Simon Horman
2008-08-05 11:14 ` Simon Horman
2008-08-05 11:28 ` Matthew Wilcox
2008-08-05 12:15 ` Simon Horman
2008-08-05 12:26 ` Matthew Wilcox
2008-08-06 0:57 ` Simon Horman
2008-08-06 13:19 ` Matthew Wilcox
2008-08-06 23:25 ` Simon Horman
2008-08-06 23:30 ` Simon Horman
2008-08-07 0:30 ` Michael Ellerman [this message]
2008-08-07 1:06 ` Simon Horman
2008-08-07 4:56 ` Simon Horman
2008-08-07 16:50 ` Jesse Barnes
2008-08-07 22:59 ` Simon Horman
2008-08-05 13:21 ` Sven Wegener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218069026.7900.0.camel@localhost \
--to=michael@ellerman.id.au \
--cc=horms@verge.net.au \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=sven.wegener@stealer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.