All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Miller <davem@davemloft.net>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	stable@kernel.org
Subject: Re: [PATCH]: radeonfb: Fix copyarea for R300 and later.
Date: Thu, 07 Aug 2008 15:52:49 +1000	[thread overview]
Message-ID: <1218088369.24157.268.camel@pasglop> (raw)
In-Reply-To: <1218074816.24157.266.camel@pasglop>


>  
> +	/* Ensure the dst cache is flushed and the engine idle before
> +	 * issuing the operation.
> +	 *
> +	 * This works around engine lockups on some cards
> +	 */
> +	OUTREG(DSTCACHE_CTLSTAT, RB2D_DC_FLUSH_ALL);
> +	OUTREG(WAIT_UNTIL, (WAIT_2D_IDLECLEAN | WAIT_DMA_GUI_IDLE));
> +
>  	radeon_fifo_wait(2);  

Typo in the patch, missing radeon_fifo_wait before the cache flush.

Fixed version on it's way, sorry.

Cheers,
Ben.



  reply	other threads:[~2008-08-07  6:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-06  7:35 [PATCH]: radeonfb: Fix copyarea for R300 and later David Miller
2008-08-06 15:43 ` Andrew Morton
2008-08-06 21:19   ` David Miller
2008-08-06 22:08     ` Benjamin Herrenschmidt
2008-08-07  2:06     ` Benjamin Herrenschmidt
2008-08-07  5:52       ` Benjamin Herrenschmidt [this message]
2008-08-07 11:22         ` Geert Uytterhoeven
2008-08-07 21:24           ` Benjamin Herrenschmidt
2008-08-07  8:52     ` [PATCH] radeonfb: Fix engine hangs and cache flushing (v2) Benjamin Herrenschmidt
2008-08-06 22:09   ` [PATCH]: radeonfb: Fix copyarea for R300 and later Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218088369.24157.268.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.