From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] fm10k: fix a crash bug when quit from testpmd Date: Tue, 24 Nov 2015 11:39:19 +0100 Message-ID: <12180988.okvxpfoiHK@xps13> References: <1447304251-4145-1-git-send-email-jing.d.chen@intel.com> <1448334616-14540-1-git-send-email-jing.d.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Chen Jing D(Mark)" Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id B4D4258D8 for ; Tue, 24 Nov 2015 11:40:36 +0100 (CET) Received: by wmww144 with SMTP id w144so20208025wmw.0 for ; Tue, 24 Nov 2015 02:40:36 -0800 (PST) In-Reply-To: <1448334616-14540-1-git-send-email-jing.d.chen@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-24 11:10, Chen Jing D: > When the fm10k port is closed, both func tx_queue_clean() and > fm10k_tx_queue_release_mbufs_vec() will try to release buffer in > SW ring. The latter func won't do sanity check on those pointers > and cause crash. > > The fix removed Vector TX buffer release func since it can share > the release functions with regular TX. > > fixes: fb9066e479a6(fm10k: reset and release mbuf) > > Signed-off-by: Chen Jing D(Mark) > Acked-by: Michael Qiu Applied, thanks