From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@hp.com>
Subject: [PATCH][LINUX] don't WARN_ON -ENOSYS from
	PHYSDEVOP_manage_pci_remove
Date: Thu, 07 Aug 2008 15:17:10 -0600
Message-ID: <1218143830.4867.69.camel@lappy>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel <xen-devel@lists.xensource.com>
Cc: Keir Fraser <keir.fraser@citrix.com>
List-Id: xen-devel@lists.xenproject.org


We let -ENOSYS slip through on the add side to support old hypervisors,
let's do the same on the remove end so we don't get stack dumps during
bootup.

Signed-off-by: Alex Williamson <alex.williamson@hp.com>
--

diff -r 2866e6af503e drivers/xen/core/pci.c
--- a/drivers/xen/core/pci.c	Thu Jul 31 15:33:54 2008 +0100
+++ b/drivers/xen/core/pci.c	Thu Aug 07 15:14:07 2008 -0600
@@ -23,9 +23,13 @@ static int pci_bus_probe_wrapper(struct 
 		return r;
 
 	r = pci_bus_probe(dev);
-	if (r)
-		WARN_ON(HYPERVISOR_physdev_op(PHYSDEVOP_manage_pci_remove,
-					      &manage_pci));
+	if (r) {
+		int ret;
+
+		ret = HYPERVISOR_physdev_op(PHYSDEVOP_manage_pci_remove,
+					    &manage_pci);
+		WARN_ON(ret && ret != -ENOSYS);
+	}
 
 	return r;
 }