From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Subject: Re: [PATCH -v2 6/8] kexec jump: fix for lockdep From: Peter Zijlstra In-Reply-To: <1218178365.22039.79.camel@caritas-dev.intel.com> References: <1218178365.22039.79.camel@caritas-dev.intel.com> Date: Fri, 08 Aug 2008 12:13:46 +0200 Message-Id: <1218190426.8625.71.camel@twins> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Huang Ying Cc: nigel@nigel.suspend2.net, Kexec Mailing List , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , "Eric W. Biederman" , Pavel Machek , Andrew Morton , Linus Torvalds , mingo@elte.hu, Vivek Goyal On Fri, 2008-08-08 at 14:52 +0800, Huang Ying wrote: > Replace local_irq_disable() with raw_local_irq_disable() to prevent > lockdep complain. Uhhm, please provide more information - just using raw_* to silence lockdep is generally the wrong thing to do. > Signed-off-by: Huang Ying > > --- > arch/x86/kernel/machine_kexec_32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/x86/kernel/machine_kexec_32.c > +++ b/arch/x86/kernel/machine_kexec_32.c > @@ -123,7 +123,7 @@ void machine_kexec(struct kimage *image) > tracer_disable(); > > /* Interrupts aren't acceptable while we reboot */ > - local_irq_disable(); > + raw_local_irq_disable(); > > if (image->preserve_context) { > #ifdef CONFIG_X86_IO_APIC > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757476AbYHHKOp (ORCPT ); Fri, 8 Aug 2008 06:14:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757518AbYHHKOZ (ORCPT ); Fri, 8 Aug 2008 06:14:25 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:58576 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755290AbYHHKOY (ORCPT ); Fri, 8 Aug 2008 06:14:24 -0400 Subject: Re: [PATCH -v2 6/8] kexec jump: fix for lockdep From: Peter Zijlstra To: Huang Ying Cc: "Eric W. Biederman" , Pavel Machek , nigel@nigel.suspend2.net, "Rafael J. Wysocki" , Andrew Morton , Vivek Goyal , mingo@elte.hu, Linus Torvalds , linux-kernel@vger.kernel.org, Kexec Mailing List In-Reply-To: <1218178365.22039.79.camel@caritas-dev.intel.com> References: <1218178365.22039.79.camel@caritas-dev.intel.com> Content-Type: text/plain Date: Fri, 08 Aug 2008 12:13:46 +0200 Message-Id: <1218190426.8625.71.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2008-08-08 at 14:52 +0800, Huang Ying wrote: > Replace local_irq_disable() with raw_local_irq_disable() to prevent > lockdep complain. Uhhm, please provide more information - just using raw_* to silence lockdep is generally the wrong thing to do. > Signed-off-by: Huang Ying > > --- > arch/x86/kernel/machine_kexec_32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/x86/kernel/machine_kexec_32.c > +++ b/arch/x86/kernel/machine_kexec_32.c > @@ -123,7 +123,7 @@ void machine_kexec(struct kimage *image) > tracer_disable(); > > /* Interrupts aren't acceptable while we reboot */ > - local_irq_disable(); > + raw_local_irq_disable(); > > if (image->preserve_context) { > #ifdef CONFIG_X86_IO_APIC > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/