All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Walls <awalls@radix.net>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: video4linux-list@redhat.com, ivtv-devel@ivtvdriver.org
Subject: Re: CX18 Oops
Date: Fri, 08 Aug 2008 10:44:11 -0400	[thread overview]
Message-ID: <1218206651.3003.54.camel@morgan.walls.org> (raw)
In-Reply-To: <200808081635.20640.hverkuil@xs4all.nl>

On Fri, 2008-08-08 at 16:35 +0200, Hans Verkuil wrote:
> On Friday 08 August 2008 16:18:28 Andy Walls wrote:

> No objection at all. If you look at where cx18_queue_move is used, then 
> you'll notice that it is only in cx18_flush_queues(). And all it has to 
> do there is to move any buffers in the q_io or q_full queue to the 
> q_free queue and initialize all those buffers to their initial state. 
> You do not need all that complicated code for that. I suggest that you 
> make a new function instead that replaces cx18_queue_move and 
> cx18_queue_move_buf.

:)

I was especially annoyed at the local var that was named 'from_free' but
that was also used being for transfers *to* q_free, which happened to be
cx18's only use case for the variable.,,,

Regards,
Andy


> Regards,
> 
> 	Hans
> 

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  reply	other threads:[~2008-08-08 14:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-06  1:04 CX18 Oops Brandon Jenkins
2008-08-06  1:29 ` Andy Walls
2008-08-06 10:57   ` Brandon Jenkins
2008-08-07  0:55     ` Andy Walls
2008-08-07 10:16       ` Brandon Jenkins
2008-08-07 13:36       ` Brandon Jenkins
2008-08-08  0:46         ` Andy Walls
2008-08-08 14:18         ` Andy Walls
2008-08-08 14:35           ` Hans Verkuil
2008-08-08 14:44             ` Andy Walls [this message]
2008-08-09 17:43           ` Brandon Jenkins
2008-08-11 21:33           ` Brandon Jenkins
2008-08-17  2:13             ` Andy Walls
2008-08-17  9:41               ` Hans Verkuil
2008-08-17 19:12                 ` Andy Walls
2008-08-17 20:01                   ` Hans Verkuil
2008-08-18  2:53                     ` Andy Walls
2008-08-18 10:35               ` Brandon Jenkins
2008-08-18 17:17                 ` Brandon Jenkins
2008-08-19  0:34                   ` Andy Walls
2008-08-23 21:44                   ` Andy Walls
2008-08-25 19:14                     ` Brandon Jenkins
2008-08-18 23:52                 ` Andy Walls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218206651.3003.54.camel@morgan.walls.org \
    --to=awalls@radix.net \
    --cc=hverkuil@xs4all.nl \
    --cc=ivtv-devel@ivtvdriver.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.