From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Mike Travis <travis@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Yinghai Lu <yhlu.kernel@gmail.com>
Subject: [PATCH 36/42] x86_64: introduce irq_cfg_with_new
Date: Fri, 8 Aug 2008 14:52:42 -0700 [thread overview]
Message-ID: <1218232368-31228-37-git-send-email-yhlu.kernel@gmail.com> (raw)
In-Reply-To: <1218232368-31228-36-git-send-email-yhlu.kernel@gmail.com>
So could only call that one time, when we call add_irq_2_pin
Singed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
---
arch/x86/kernel/io_apic_64.c | 16 +++++++++++-----
1 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/io_apic_64.c b/arch/x86/kernel/io_apic_64.c
index fc1c6ba..1466e4b 100644
--- a/arch/x86/kernel/io_apic_64.c
+++ b/arch/x86/kernel/io_apic_64.c
@@ -135,7 +135,7 @@ static void __init init_work(void *data)
static struct irq_cfg *irq_cfgx;
DEFINE_DYN_ARRAY(irq_cfgx, sizeof(struct irq_cfg), nr_irq_cfg, PAGE_SIZE, init_work);
-static struct irq_cfg *irq_cfg_without_new(unsigned int irq)
+static struct irq_cfg *irq_cfg(unsigned int irq)
{
struct irq_cfg *cfg;
@@ -155,7 +155,7 @@ static struct irq_cfg *irq_cfg_without_new(unsigned int irq)
return NULL;
}
-static struct irq_cfg *irq_cfg(unsigned int irq)
+static struct irq_cfg *irq_cfg_with_new(unsigned int irq)
{
struct irq_cfg *cfg, *cfg_pri;
int i;
@@ -545,7 +545,8 @@ static void add_pin_to_irq(unsigned int irq, int apic, int pin)
struct irq_cfg *cfg;
struct irq_pin_list *entry;
- cfg = irq_cfg(irq);
+ /* first time to refer irq_cfg, so with new */
+ cfg = irq_cfg_with_new(irq);
entry = cfg->irq_2_pin;
if (!entry) {
entry = get_one_free_irq_2_pin();
@@ -1208,13 +1209,15 @@ static int setup_ioapic_entry(int apic, int irq,
static void setup_IO_APIC_irq(int apic, int pin, unsigned int irq,
int trigger, int polarity)
{
- struct irq_cfg *cfg = irq_cfg(irq);
+ struct irq_cfg *cfg;
struct IO_APIC_route_entry entry;
cpumask_t mask;
if (!IO_APIC_IRQ(irq))
return;
+ cfg = irq_cfg(irq);
+
mask = TARGET_CPUS;
if (assign_irq_vector(irq, mask))
return;
@@ -2490,8 +2493,11 @@ int create_irq(void)
if (platform_legacy_irq(new))
continue;
cfg_new = irq_cfg(new);
- if (cfg_new->vector != 0)
+ if (cfg_new && cfg_new->vector != 0)
continue;
+ /* check if need to create one */
+ if (!cfg_new)
+ cfg_new = irq_cfg_with_new(new);
if (__assign_irq_vector(new, TARGET_CPUS) == 0)
irq = new;
break;
--
1.5.4.5
next prev parent reply other threads:[~2008-08-08 22:07 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 21:52 [PATCH 00/42] dyn_array/nr_irqs/sparse_irq support v5 Yinghai Lu
2008-08-08 21:52 ` [PATCH 01/42] 8250: Remove NR_IRQ usage Yinghai Lu
2008-08-08 21:52 ` [PATCH 02/42] x86: add after_bootmem for 32bit Yinghai Lu
2008-08-08 21:52 ` [PATCH 03/42] x86: remove irq_vectors_limits Yinghai Lu
2008-08-08 21:52 ` [PATCH 04/42] add dyn_array support Yinghai Lu
2008-08-08 21:52 ` [PATCH 05/42] add per_cpu_dyn_array support Yinghai Lu
2008-08-08 21:52 ` [PATCH 06/42] x86: alloc dyn_array all alltogether Yinghai Lu
2008-08-08 21:52 ` [PATCH 07/42] x86: enable dyn_array support Yinghai Lu
2008-08-08 21:52 ` [PATCH 08/42] introduce nr_irqs Yinghai Lu
2008-08-08 21:52 ` [PATCH 09/42] x86: using nr_irqs Yinghai Lu
2008-08-08 21:52 ` [PATCH 10/42] drivers/char to use nr_irqs Yinghai Lu
2008-08-08 21:52 ` [PATCH 11/42] drivers/net " Yinghai Lu
2008-08-08 21:52 ` [PATCH 12/42] drivers intr remapping " Yinghai Lu
2008-08-08 21:52 ` [PATCH 13/42] drivers/pcmcia " Yinghai Lu
2008-08-08 21:52 ` [PATCH 14/42] drivers/rtc " Yinghai Lu
2008-08-08 21:52 ` [PATCH 15/42] drivers/scsi " Yinghai Lu
2008-08-08 21:52 ` [PATCH 16/42] drivers/serial " Yinghai Lu
2008-08-08 21:52 ` [PATCH 17/42] drivers proc " Yinghai Lu
2008-08-08 21:52 ` [PATCH 18/42] drivers xen events " Yinghai Lu
2008-08-08 21:52 ` [PATCH 19/42] make irq_timer_state to use dyn_array Yinghai Lu
2008-08-08 21:52 ` [PATCH 20/42] make irq2_iommu " Yinghai Lu
2008-08-08 21:52 ` [PATCH 21/42] make irq_desc " Yinghai Lu
2008-08-08 21:52 ` [PATCH 22/42] irq: make irqs in kernel stat use per_cpu_dyn_array Yinghai Lu
2008-08-08 21:52 ` [PATCH 23/42] x86: use dyn_array in io_apic_xx.c Yinghai Lu
2008-08-08 21:52 ` [PATCH 24/42] x86: get mp_irqs from madt Yinghai Lu
2008-08-08 21:52 ` [PATCH 25/42] x86: remove nr_irq_vectors Yinghai Lu
2008-08-08 21:52 ` [PATCH 26/42] x86_64: use irq_desc() together with dyn_array Yinghai Lu
2008-08-08 21:52 ` [PATCH 27/42] x86: add irq_cfg in io_apic_64.c Yinghai Lu
2008-08-08 21:52 ` [PATCH 28/42] x86: put irq_2_pin pointer into irq_cfg Yinghai Lu
2008-08-08 21:52 ` [PATCH 29/42] x86: put timer_rand_state pointer into irq_desc Yinghai Lu
2008-08-08 21:52 ` [PATCH 30/42] x86: move kstat_irqs from kstat to irq_desc Yinghai Lu
2008-08-08 21:52 ` [PATCH 31/42] replace loop with nr_irqs with for_each_irq_desc Yinghai Lu
2008-08-08 21:52 ` [PATCH 32/42] replace loop with nr_irqs with for_each_irq_icfg Yinghai Lu
2008-08-08 21:52 ` [PATCH 33/42] remove >= nr_irqs checking with config_have_sparse_irq Yinghai Lu
2008-08-08 21:52 ` [PATCH 34/42] x86_64: add irq_desc in function in paramater Yinghai Lu
2008-08-08 21:52 ` [PATCH 35/42] x86: check with without_new in show_interrupts Yinghai Lu
2008-08-08 21:52 ` Yinghai Lu [this message]
2008-08-08 21:52 ` [PATCH 37/42] x86_64: introduce irq_desc_with_new Yinghai Lu
2008-08-08 21:52 ` [PATCH 38/42] seperate irq_descX with irq_descX_free Yinghai Lu
2008-08-08 21:52 ` [PATCH 39/42] x86_64: sperate irq_cfgx with irq_cfgx_free Yinghai Lu
2008-08-08 21:52 ` [PATCH 40/42] x86_64: make /proc/interrupts works with dyn irq_desc Yinghai Lu
2008-08-08 21:52 ` [PATCH 41/42] x86_64: remove one nr_irqs in show_stat Yinghai Lu
2008-08-08 21:52 ` [PATCH 42/42] x86: put irq_2_iommu pointer into irq_desc Yinghai Lu
2008-08-09 1:00 ` [PATCH 08/42] introduce nr_irqs Eric W. Biederman
2008-08-09 1:38 ` Yinghai Lu
2008-08-09 1:59 ` H. Peter Anvin
2008-08-09 7:30 ` Yinghai Lu
2008-08-09 16:02 ` Eric W. Biederman
2008-08-09 21:21 ` Yinghai Lu
2008-08-09 21:38 ` Eric W. Biederman
2008-08-09 22:35 ` Yinghai Lu
2008-08-09 6:07 ` Eric W. Biederman
2008-08-09 7:30 ` Yinghai Lu
2008-08-09 15:46 ` Eric W. Biederman
2008-08-09 21:37 ` Yinghai Lu
2008-08-08 22:38 ` [PATCH 01/42] 8250: Remove NR_IRQ usage Eric W. Biederman
2008-08-08 23:07 ` Yinghai Lu
2008-08-08 22:01 ` [PATCH 00/42] dyn_array/nr_irqs/sparse_irq support v5 H. Peter Anvin
2008-08-08 22:14 ` Yinghai Lu
2008-08-08 22:25 ` H. Peter Anvin
2008-08-08 22:30 ` Yinghai Lu
2008-08-08 22:33 ` H. Peter Anvin
2008-08-08 22:19 ` H. Peter Anvin
2008-08-08 22:26 ` Yinghai Lu
2008-08-08 23:40 ` Eric W. Biederman
2008-08-09 0:34 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218232368-31228-37-git-send-email-yhlu.kernel@gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.