All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harvey Harrison <harvey.harrison@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] cred: add static, remove extern on function definitions
Date: Sat, 09 Aug 2008 15:56:59 -0700	[thread overview]
Message-ID: <1218322619.24441.6.camel@brick> (raw)

kernel/cred.c:460:13: warning: function 'revert_creds' with external linkage has definition
kernel/cred.c:72:6: warning: symbol 'put_tgcred' was not declared. Should it be static?

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Introduced between next-20080729 and next-20080808

 kernel/cred.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/cred.c b/kernel/cred.c
index f89c5e5..d91cb06 100644
--- a/kernel/cred.c
+++ b/kernel/cred.c
@@ -69,7 +69,7 @@ static void put_tgcred_rcu(struct rcu_head *rcu)
 /*
  * Release a set of thread group credentials.
  */
-void put_tgcred(struct thread_group_cred *tgcred)
+static void put_tgcred(struct thread_group_cred *tgcred)
 {
 	if (atomic_dec_and_test(&tgcred->usage))
 		call_rcu(&tgcred->rcu, put_tgcred_rcu);
@@ -457,7 +457,7 @@ EXPORT_SYMBOL(override_creds);
  * Revert a temporary set of override subjective credentials to an old set,
  * discarding the override set.
  */
-extern void revert_creds(const struct cred *old)
+void revert_creds(const struct cred *old)
 {
 	const struct cred *override = current->cred;
 
-- 
1.6.0.rc1.278.g9c632


             reply	other threads:[~2008-08-09 22:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-09 22:56 Harvey Harrison [this message]
2008-08-10 11:01 ` [PATCH] cred: add static, remove extern on function definitions David Howells
2008-08-10 22:45   ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218322619.24441.6.camel@brick \
    --to=harvey.harrison@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.