From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KS9nw-00048U-HQ for mharc-grub-devel@gnu.org; Sun, 10 Aug 2008 08:13:48 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KS9nu-00048N-T4 for grub-devel@gnu.org; Sun, 10 Aug 2008 08:13:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KS9nt-000481-Bz for grub-devel@gnu.org; Sun, 10 Aug 2008 08:13:46 -0400 Received: from [199.232.76.173] (port=36079 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KS9nt-00047y-6W for grub-devel@gnu.org; Sun, 10 Aug 2008 08:13:45 -0400 Received: from moutng.kundenserver.de ([212.227.126.177]:55075) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KS9nt-0007Sh-9R for grub-devel@gnu.org; Sun, 10 Aug 2008 08:13:45 -0400 Received: from [85.180.6.212] (e180006212.adsl.alicedsl.de [85.180.6.212]) by mrelayeu.kundenserver.de (node=mrelayeu6) with ESMTP (Nemesis) id 0ML29c-1KS9nW0c9y-0001XI; Sun, 10 Aug 2008 14:13:22 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: References: Content-Type: text/plain Date: Sun, 10 Aug 2008 14:13:24 +0200 Message-Id: <1218370404.7284.7.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX18Zw6sk0kHFpDR3Zs1e/OBjC7jDjNnoExlrXp1 Lg8JB50d+wyzM2qcwYmlbhgMTu4un3UaPnYcz4r1Pt+kPJgtBw N4rxO0g4qSofLLXUqmqMM+zimc6F1si X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) Cc: 494501-forwarded@bugs.debian.org Subject: Re: [PATCH] Split of raid scan code X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Aug 2008 12:13:47 -0000 Am Sonntag, den 10.08.2008, 19:52 +0800 schrieb Bean: > Hi, > > This patch seperate the scan code from raid.c, and move it to > mdraid.c. raid.c only contain generic raid handling code now. This > make it much easier to extend to other raid layout, like various > fakeraids. > Really great that you work now on the RAID Code. Today morning (for me) there just came another bugreport on Debian BTS in about RAID [0] This should probable go into lenny and so I probable have to make a change for this anyway. It's just the same as with these invalid BSD disklabels/partitions. The return grub_error should be better changed to an grub_dprintf() + return 0; for unknown RAID Levels. Unknown RAID levels should be better just ignored, i.e. just not added to the RAID array list instead of whole GRUB dropping to rescue mode. [0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=494501