From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KSvpE-0002Vx-6q
	for mharc-grub-devel@gnu.org; Tue, 12 Aug 2008 11:30:20 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KSvpC-0002VU-9l
	for grub-devel@gnu.org; Tue, 12 Aug 2008 11:30:18 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KSvp8-0002Sd-Vn
	for grub-devel@gnu.org; Tue, 12 Aug 2008 11:30:17 -0400
Received: from [199.232.76.173] (port=59669 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KSvp8-0002SQ-2w
	for grub-devel@gnu.org; Tue, 12 Aug 2008 11:30:14 -0400
Received: from moutng.kundenserver.de ([212.227.126.171]:61413)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fzielcke@z-51.de>) id 1KSvp6-0000Ty-N5
	for grub-devel@gnu.org; Tue, 12 Aug 2008 11:30:13 -0400
Received: from [85.180.52.249] (e180052249.adsl.alicedsl.de [85.180.52.249])
	by mrelayeu.kundenserver.de (node=mrelayeu4) with ESMTP (Nemesis)
	id 0ML21M-1KSvp51Frp-00088n; Tue, 12 Aug 2008 17:30:11 +0200
From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Content-Type: multipart/mixed; boundary="=-uk9Lo0tTXvNvQY67ZhIG"
Date: Tue, 12 Aug 2008 17:30:15 +0200
Message-Id: <1218555015.1604.6.camel@fz.local>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 
X-Provags-ID: V01U2FsdGVkX1+4lgbkkeXsse6rCXQ4dKbfKbdq4MYwXzmeYX4
	N6s2ww/nmcZf8T+GsT6kJs82IGe6WQH4EFNlFWWGbE2tkLBId7
	Dt7nRHWKjf9t+eM/n58Wklg0pCRqQmc
X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!)
Subject: [PATCH] change grub_print_error to use stderr for the utils
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Aug 2008 15:30:18 -0000


--=-uk9Lo0tTXvNvQY67ZhIG
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Here's now the patch Robert requested.
grub_print_error shouldn't use stdout for the utils.

Why?

# grub-install /dev/sda
Unknown extra argument `Unsupported'.

This is with Bean's or mine lastest RAID patch.
/dev/sda isn't on a raid at all.
There are 4 disks attached to the VM which have a RAID 6 on it.
But the RAID 6 isn't even assembled, i.e. /proc/mdstat says nothing.

As always, the changelog isn't probable that perfect for you, so please comment :)

2008-08-12  Felix Zielcke <fzielcke@z-51.de>

        * kern/err.c [GRUB_UTIL]: Include <stdio.h>.
          (grub_print_error) [GRUB_UTIL]: Use fprintf (stderr, ...) instead of 
          grub_printf.


--=-uk9Lo0tTXvNvQY67ZhIG
Content-Disposition: attachment; filename=kern_err.diff
Content-Type: text/x-patch; name=kern_err.diff; charset=UTF-8
Content-Transfer-Encoding: 7bit

Index: kern/err.c
===================================================================
--- kern/err.c	(revision 1800)
+++ kern/err.c	(working copy)
@@ -21,6 +21,9 @@
 #include <grub/misc.h>
 #include <stdarg.h>
 
+#ifdef GRUB_UTIL
+#include <stdio.h>
+#endif
 #define GRUB_MAX_ERRMSG		256
 #define GRUB_ERROR_STACK_SIZE	10
 
@@ -121,7 +124,11 @@
   do
     {
       if (grub_errno != GRUB_ERR_NONE)
+#ifdef GRUB_UTIL
+	fprintf (stderr, "error: %s\n");
+#else
         grub_printf ("error: %s\n", grub_errmsg);
+#endif
     } 
   while (grub_error_pop ());
   

--=-uk9Lo0tTXvNvQY67ZhIG--