From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KSvto-0005qG-PG
	for mharc-grub-devel@gnu.org; Tue, 12 Aug 2008 11:35:04 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KSvtn-0005pm-Cl
	for grub-devel@gnu.org; Tue, 12 Aug 2008 11:35:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KSvtk-0005oe-Mw
	for grub-devel@gnu.org; Tue, 12 Aug 2008 11:35:02 -0400
Received: from [199.232.76.173] (port=40061 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KSvtk-0005oQ-Fn
	for grub-devel@gnu.org; Tue, 12 Aug 2008 11:35:00 -0400
Received: from moutng.kundenserver.de ([212.227.126.187]:56349)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fzielcke@z-51.de>) id 1KSvtj-0001JH-Ut
	for grub-devel@gnu.org; Tue, 12 Aug 2008 11:35:00 -0400
Received: from [85.180.52.249] (e180052249.adsl.alicedsl.de [85.180.52.249])
	by mrelayeu.kundenserver.de (node=mrelayeu6) with ESMTP (Nemesis)
	id 0ML29c-1KSvtj0e4y-0001ST; Tue, 12 Aug 2008 17:34:59 +0200
From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
In-Reply-To: <1218555015.1604.6.camel@fz.local>
References: <1218555015.1604.6.camel@fz.local>
Content-Type: multipart/mixed; boundary="=-Zc5oD9jU+OCH+6yfkVYG"
Date: Tue, 12 Aug 2008 17:35:03 +0200
Message-Id: <1218555303.1604.8.camel@fz.local>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 
X-Provags-ID: V01U2FsdGVkX1+1+vgY/HMVx9+gzDZW5Yxjf55pqUz8Q9SF189
	pBhqvqXx1Tae+6g877d4oTh2g9eSby9UopQxemrqkUO5+ISwAy
	dtFY+ypFrC6jcqZmZfn7fBMavuKKK86
X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!)
Subject: Re: [PATCH] change grub_print_error to use stderr for the utils
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Aug 2008 15:35:03 -0000


--=-Zc5oD9jU+OCH+6yfkVYG
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Am Dienstag, den 12.08.2008, 17:30 +0200 schrieb Felix Zielcke:
> Here's now the patch Robert requested.
> grub_print_error shouldn't use stdout for the utils.
> 
Bah and I attached the broken one not the working one.
So please use that one.

--=-Zc5oD9jU+OCH+6yfkVYG
Content-Disposition: attachment; filename=kern_err.diff
Content-Type: text/x-patch; name=kern_err.diff; charset=UTF-8
Content-Transfer-Encoding: 7bit

Index: kern/err.c
===================================================================
--- kern/err.c	(revision 1800)
+++ kern/err.c	(working copy)
@@ -21,6 +21,9 @@
 #include <grub/misc.h>
 #include <stdarg.h>
 
+#ifdef GRUB_UTIL
+#include <stdio.h>
+#endif
 #define GRUB_MAX_ERRMSG		256
 #define GRUB_ERROR_STACK_SIZE	10
 
@@ -121,7 +124,11 @@
   do
     {
       if (grub_errno != GRUB_ERR_NONE)
+#ifdef GRUB_UTIL
+	fprintf (stderr, "error: %s\n", grub_errmsg);
+#else
         grub_printf ("error: %s\n", grub_errmsg);
+#endif
     } 
   while (grub_error_pop ());
   

--=-Zc5oD9jU+OCH+6yfkVYG--