From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KSx8M-0000iw-MK
	for mharc-grub-devel@gnu.org; Tue, 12 Aug 2008 12:54:10 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KSx8K-0000g5-BR
	for grub-devel@gnu.org; Tue, 12 Aug 2008 12:54:08 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KSx8I-0000dX-Cv
	for grub-devel@gnu.org; Tue, 12 Aug 2008 12:54:07 -0400
Received: from [199.232.76.173] (port=47575 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KSx8H-0000dL-Jo
	for grub-devel@gnu.org; Tue, 12 Aug 2008 12:54:05 -0400
Received: from moutng.kundenserver.de ([212.227.126.183]:63087)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fzielcke@z-51.de>) id 1KSx8G-0007We-WB
	for grub-devel@gnu.org; Tue, 12 Aug 2008 12:54:05 -0400
Received: from [85.180.52.249] (e180052249.adsl.alicedsl.de [85.180.52.249])
	by mrelayeu.kundenserver.de (node=mrelayeu4) with ESMTP (Nemesis)
	id 0ML21M-1KSx8F2sLM-0007tn; Tue, 12 Aug 2008 18:54:03 +0200
From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
In-Reply-To: <1218555015.1604.6.camel@fz.local>
References: <1218555015.1604.6.camel@fz.local>
Content-Type: text/plain
Date: Tue, 12 Aug 2008 18:54:07 +0200
Message-Id: <1218560047.19045.15.camel@fz.local>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 
Content-Transfer-Encoding: 7bit
X-Provags-ID: V01U2FsdGVkX18rJp+FxXqOgqq2iXxgJUkPTJYOaSFRm5Cc9N8
	/+U43/xvFzy8sVsbzeyL89wKdEyUfySwsg3Mq0z/LITVwkNw6h
	1+fg8wlYr+K9JBpxSkE0pw5nzrKsxqk
X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!)
Subject: Re: [PATCH] change grub_print_error to use stderr for the utils
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Aug 2008 16:54:09 -0000

Am Dienstag, den 12.08.2008, 17:30 +0200 schrieb Felix Zielcke:
> Here's now the patch Robert requested.
> grub_print_error shouldn't use stdout for the utils.
> 
> Why?
> 
> # grub-install /dev/sda
> Unknown extra argument `Unsupported'.
> 

Ok this is only clear for Bean, Robert and me :)
So here's a longer explaination for this.

The Unsupported comes from here

fz@fz:~/grub/grub2.svn$ grep -r "Unsupported" *
disk/raid.c:		  "Unsupported RAID version: %d.%d",
disk/raid.c:		  "Unsupported RAID level: %d",
disk/raid.c:		  "Unsupported RAID5 layout: %d",

In my case it's Unsupported RAID level: 6

The problem is grub_print_error () uses stdout even for grub-probe which
is used by the grub-install script
So instead of ext2 or whatever grub-probe would display for
grub-install, grub-install get's Unsupported.

It isn't right to use stdout for errors in the utils.
real grub of course doestn't care about stdout or stderr.