From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KTKNd-000789-7G for mharc-grub-devel@gnu.org; Wed, 13 Aug 2008 13:43:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTKNa-00077r-VF for grub-devel@gnu.org; Wed, 13 Aug 2008 13:43:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTKNZ-00077f-3P for grub-devel@gnu.org; Wed, 13 Aug 2008 13:43:26 -0400 Received: from [199.232.76.173] (port=46371 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTKNY-00077c-TS for grub-devel@gnu.org; Wed, 13 Aug 2008 13:43:24 -0400 Received: from mx20.gnu.org ([199.232.41.8]:2350) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KTKNY-0006lp-GH for grub-devel@gnu.org; Wed, 13 Aug 2008 13:43:24 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KTKN3-0007CB-41 for grub-devel@gnu.org; Wed, 13 Aug 2008 13:42:53 -0400 Received: from [85.180.44.194] (e180044194.adsl.alicedsl.de [85.180.44.194]) by mrelayeu.kundenserver.de (node=mrelayeu6) with ESMTP (Nemesis) id 0ML29c-1KTKLT11D1-0001ug; Wed, 13 Aug 2008 19:41:28 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <87ljz1b6gc.fsf@xs4all.nl> References: <1218555015.1604.6.camel@fz.local> <87ljz1b6gc.fsf@xs4all.nl> Content-Type: text/plain Date: Wed, 13 Aug 2008 19:35:26 +0200 Message-Id: <1218648926.9951.12.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1/TsA9xmE+utpn4aPi+IB6Ko4Wji2n0uVZL4WU +FWEL5R7BSFmZSLFBYMInAtR6nrnrrct7++rpeMrXc3qspyFaS 1OVK+HvcmkwMBMpheDSxnUnBDclKRHp X-detected-kernel: by mx20.gnu.org: Linux 2.6? (barebone, rare!) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Subject: [RFC] change grub_print_error to use stderr for the utils X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Aug 2008 17:43:27 -0000 Hello, Am Mittwoch, den 13.08.2008, 11:38 +0200 schrieb Marco Gerards: > > 2008-08-12 Felix Zielcke > > > > * kern/err.c [GRUB_UTIL]: Include . > > (grub_print_error) [GRUB_UTIL]: Use fprintf (stderr, ...) instead of > > grub_printf. > > If there is another way to do this, I would prefer this. Now with remaking that grub_print_error () patch I began to doubt if that `GRUB fears raid 6 so much that it goes to rescue mode if it just sees one which it doestn't need to access at all' should be changed for lenny. Robert confirmed my doubts on IRC i.e. he said, it's better to discuss the whole thing first. This is my first mail about this: Message-Id: <1218454936.4035.19.camel@fz.local> just using grub_dprintf isn't that great, I'd like to have at least `grub-probe -vv' show the unknown RAID level message. The other patch, which changes grub_print_error () to use stderr and let the raid.mod itself print the error instead of giving it to the upper layer isn't that great either. Real GRUB shows for every RAID 6 disk once `unknown RAID level 6' e.g. in my VMware testcase with 4 disks 4 times. grub-install /dev/sda with raid 6 not even assembled i.e. empty /proc/mdstat shows it 6 times, I think once for each time grub-probe gets called. By the way my last patch isn't even compiling because I forgot to make some other stuff from kern/err.c avaible to it i.e. grub_error_stack_assert is declared as static but used in grub_print_error () and there's another problem grub-mkimage includes util/misc.c but not kern/err.c so the other functions and variables needed by it aren't avaible. So please comment this.