From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KTN0L-0005ni-9p for mharc-grub-devel@gnu.org; Wed, 13 Aug 2008 16:31:37 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTN0J-0005n5-Bg for grub-devel@gnu.org; Wed, 13 Aug 2008 16:31:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTN0H-0005lg-OS for grub-devel@gnu.org; Wed, 13 Aug 2008 16:31:35 -0400 Received: from [199.232.76.173] (port=34068 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTN0H-0005la-FS for grub-devel@gnu.org; Wed, 13 Aug 2008 16:31:33 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:53752) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KTN0G-0007zK-Ek for grub-devel@gnu.org; Wed, 13 Aug 2008 16:31:32 -0400 Received: from [85.180.44.194] (e180044194.adsl.alicedsl.de [85.180.44.194]) by mrelayeu.kundenserver.de (node=mrelayeu0) with ESMTP (Nemesis) id 0MKwh2-1KTN0E3tkF-00079U; Wed, 13 Aug 2008 22:31:31 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <87abfhb60p.fsf@xs4all.nl> References: <1218558487.19045.8.camel@fz.local> <1218558734.19045.10.camel@fz.local> <87fxp9di59.fsf@xs4all.nl> <20080812224041.GB3141@thorin> <1218606980.4008.9.camel@fz.local> <87abfhb60p.fsf@xs4all.nl> Content-Type: text/plain Date: Wed, 13 Aug 2008 22:31:36 +0200 Message-Id: <1218659496.25595.7.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX18qD4nCvt2kZmZvcaynejrc2ZZka1jG5ecxr/3 kZqK4ddIVchpdR6TKSA+/6v3KSd6p7/Ztz/kt8+xVA49IPai7O +hU1vQOcna5KJGFFXzdcfFCuOEW4yGj X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) Subject: Re: [PATCH] kern/err.c + disk/raid.c error handling fixes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Aug 2008 20:31:35 -0000 Am Mittwoch, den 13.08.2008, 11:47 +0200 schrieb Marco Gerards: > Felix Zielcke writes: > > > On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote: > >> > * kern/err.c [GRUB_UTIL]: Include . > > > >> Please don't do this. Why do you want this? > > > > It's needed for fprintf, and fprintf is only useful for GRUB_UTIL. > > I understood that. With this I meant "changing the kernel for GRUB_UTIL" :) > I just did it first that way, because we need a simple and small patch for lenny (i.e. debian-release) If I do it like you prefer duplicating it in util/misc.c then I need to remove the static from `int grub_error_stack_assert;' and having it prefixed with extern on grub/err.h Yes this change is no problem, grub-probe now compiles fine But grub-mkimage not: grub_mkimage-util_misc.o: In function `grub_print_error': /home/fz/grub/grub2.svn/util/misc.c:315: undefined reference to `grub_error_pop' /home/fz/grub/grub2.svn/util/misc.c:312: undefined reference to `grub_errno' /home/fz/grub/grub2.svn/util/misc.c:313: undefined reference to `grub_errmsg' /home/fz/grub/grub2.svn/util/misc.c:313: undefined reference to `grub_printf' /home/fz/grub/grub2.svn/util/misc.c:315: undefined reference to `grub_error_pop' /home/fz/grub/grub2.svn/util/misc.c:320: undefined reference to `grub_printf' collect2: ld returned 1 exit status make: *** [grub-mkimage] Error 1 So for me it seems kern/err.c has to be either doubled for the utils or, just like I did first, with just changing 2 grub_printf to fprintf for GRUB_UTIL