From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KTXQu-0006Fy-Si for mharc-grub-devel@gnu.org; Thu, 14 Aug 2008 03:39:44 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTXQs-0006Fl-Gf for grub-devel@gnu.org; Thu, 14 Aug 2008 03:39:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTXQr-0006FY-Vf for grub-devel@gnu.org; Thu, 14 Aug 2008 03:39:42 -0400 Received: from [199.232.76.173] (port=57926 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTXQr-0006FV-PL for grub-devel@gnu.org; Thu, 14 Aug 2008 03:39:41 -0400 Received: from mx20.gnu.org ([199.232.41.8]:25028) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KTXQr-0000nk-64 for grub-devel@gnu.org; Thu, 14 Aug 2008 03:39:41 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KTXQq-0000Eh-6s for grub-devel@gnu.org; Thu, 14 Aug 2008 03:39:40 -0400 Received: from [85.180.42.216] (e180042216.adsl.alicedsl.de [85.180.42.216]) by mrelayeu.kundenserver.de (node=mrelayeu6) with ESMTP (Nemesis) id 0ML29c-1KTXQo3B0p-0001fP; Thu, 14 Aug 2008 09:39:39 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <87zlngyszj.fsf@xs4all.nl> References: <1218555015.1604.6.camel@fz.local> <87ljz1b6gc.fsf@xs4all.nl> <1218648926.9951.12.camel@fz.local> <87ljz021w9.fsf@xs4all.nl> <1218654844.10474.13.camel@fz.local> <87zlngyszj.fsf@xs4all.nl> Content-Type: text/plain Date: Thu, 14 Aug 2008 09:39:44 +0200 Message-Id: <1218699584.4065.26.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX19E9RjijNZA7qo41RkGdJss8ed7W1D9r7y6Oq1 TOVDHymaSx9gKImzYP6xiA/tZd5Zvh5zouLZj9ETkCBzUiVYt3 aRh7zAlD++NxYvKlqKlKqHt7+a2mt// X-detected-kernel: by mx20.gnu.org: Linux 2.6? (barebone, rare!) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [RFC] change grub_print_error to use stderr for the utils X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Aug 2008 07:39:42 -0000 Am Donnerstag, den 14.08.2008, 09:07 +0200 schrieb Marco Gerards: Honourly I want that whole topic discussed with everyone who is subscribed here and not just with you Marco, but it's very kind that at least you reply :) > > Well, ok. So thus we are indeed fixing a problem in Lenny inside > GRUB? On IRC someone said this was *not* the case. I am very > confused... Yeah sorry it is very confusing. I want (wanted ?) to have that problem _for_ lenny fixed. The problem (in current SVN without Bean's RAID rewrite, this won't be in lenny anway) is: As soon as real GRUB _sees_ one disk wich has a mdraid raid level 6 (or e.g. 10, it's not supported either) super block then it goes to rescue mode. First patch from me: <1218454936.4035.19.camel@fz.local> Problem: The messages get totally lost for the average user, i.e. even grub-probe --vv says nothing, that RAID 6 isn't supported. Robert suggested (20080811142856.GB15950@thorin) to handle it with grub_print_error () and grub_errno = GRUB_ERR_NONE in the raid.mod itself. Problem: With that way + my fprintf stderr change, it's displayed in real GRUB once for every disk. In grub-install /dev/sda1, where that isn't on RAID at all it's shown 6 times, I _think_ once for every grub-probe call. Bean's raid_6.diff (ca0f59980808120449s61abd11iefb197cd3b1672d5@mail.gmail.com) and my fprintf change Problem: The message on grub-install is now shown much more then just 6 times as with mine, I think more then 20 times. I haven't tried Bean's lastest patch with an unsupported RAID level like 10 now that he has RAID 6 implemented. But the problem is still there. I'd like to have that unknown RAID level message shown only once per array not for every disk. The `grub_print_error fprintf (stderr ..)' is probable the right first step, but it isn't a 100% perfect fix for this. Seems like I just have to try lastest patch from Bean, if he changed something and then maybe complain at his topic about this. For lenny Robert and me need a simple small patch to fix this. Maybe it's just better to have it for lenny unfixed.