From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KTl7S-0005y1-0q for mharc-grub-devel@gnu.org; Thu, 14 Aug 2008 18:16:34 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTl7P-0005xs-Kv for grub-devel@gnu.org; Thu, 14 Aug 2008 18:16:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTl7M-0005xL-T1 for grub-devel@gnu.org; Thu, 14 Aug 2008 18:16:30 -0400 Received: from [199.232.76.173] (port=47980 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTl7M-0005xE-M1 for grub-devel@gnu.org; Thu, 14 Aug 2008 18:16:28 -0400 Received: from nf-out-0910.google.com ([64.233.182.187]:13374) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KTl7M-0006Me-5v for grub-devel@gnu.org; Thu, 14 Aug 2008 18:16:28 -0400 Received: by nf-out-0910.google.com with SMTP id c7so463671nfi.26 for ; Thu, 14 Aug 2008 15:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer; bh=iU9gGodVk82VaBpPkjo920dgDMZ/SkRr2z7nqB3BAS4=; b=mqu6h0iAwUkpSFgjSlv2R+pRSB7j8hsgnN4AUIX8RlxLhgFUICyaumtoDWWiFRcQf6 kFVC2R5G1cmpkHZU7JjGu6T5VL9LcF27ylwV4VUNoCJY6x3yr007F3E8No0pA7RmTQBa wvrzx3UF4eD99n+abc+LLrJ6lt8sGfQ4iAoCU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer; b=hsG7O1lHsKx0mc9gli3n+/F20wCe7hJZ3TZaOb6uKF/3nC5HcHrtbfNhNXJKWGYa5a c9on4HTwA4z9sgeYdon9LQIcOeBiLeaMfOrdAI7J1MU5Ynd5VPKiuwM/ajJ394L4az5R uxwZ7Kf/5bKjVe5bj3pwmqJtbmD7mJIHlQm9o= Received: by 10.210.72.19 with SMTP id u19mr2049155eba.71.1218752187452; Thu, 14 Aug 2008 15:16:27 -0700 (PDT) Received: from ?192.168.1.100? ( [213.37.137.93]) by mx.google.com with ESMTPS id c24sm839716ika.4.2008.08.14.15.16.25 (version=SSLv3 cipher=RC4-MD5); Thu, 14 Aug 2008 15:16:26 -0700 (PDT) From: Javier =?ISO-8859-1?Q?Mart=EDn?= To: The development of GRUB 2 In-Reply-To: <87d4kb4ix2.fsf@xs4all.nl> References: <1217806150.9634.24.camel@localhost> <87iqug33m9.fsf@xs4all.nl> <1217891426.15145.38.camel@localhost> <87vdyfem5k.fsf@xs4all.nl> <1217954381.14674.31.camel@localhost> <1218296029.20937.10.camel@localhost> <87k5el9q99.fsf@xs4all.nl> <1218629785.8757.30.camel@localhost> <20080813130022.GB26618@thorin> <1218637704.8757.60.camel@localhost> <20080813151406.GA31203@thorin> <873al83o1m.fsf@xs4all.nl> <1218667095.8757.111.camel@localhost> <87d4kb4ix2.fsf@xs4all.nl> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-r0tDPge5vUsLQMzFj5UC" Date: Fri, 15 Aug 2008 00:17:26 +0200 Message-Id: <1218752246.19647.59.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: [PATCH] Drivemap module X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Aug 2008 22:16:31 -0000 --=-r0tDPge5vUsLQMzFj5UC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable El jue, 14-08-2008 a las 19:15 +0200, Marco Gerards escribi=C3=B3: > Javier Mart=C3=ADn writes: >=20 > > Ok, making a mixup reply... >=20 > Please don't. Unless you do not like it that your mails go unread. >=20 > >> > Having a small kernel is highly desireable for most users. If the k= ernel is > >> > too big, it won't fit and then either we have to use blocklists (whi= ch are > >> > unreliable), or we have to abort the install. > >> > > >> > Please, try to find a way that doesn't increase kernel size signific= antly. > >> > > >> > If the kernel interfaces are not extensible enough, you could try to= readjust > >> > them for your needs. This approach works well most of the time (alt= hough I > >> > haven't studied this particular problem in detail). > >>=20 > >> Like discussed before. Bring up such modifications like hooks up in a > >> *separate* thread. I already said that not everyone reads this > >> discussion. I will not accept a patch that changes the kernel if it > >> is part of a bigger patch that not many people read. > >>=20 > >> Please don't discuss this over with Robert and me, you know that it > >> was pointed out that this has to be a patch in a separate thread. > >> Furthermore, this is a way to get some feedback from Bean who wants > >> something similar, IIRC. > > > > I know I will be regretting saying this, but it is _very_ rude to revie= w > > some five versions of the patch, spotting mostly coding-style errors on > > each, and then, on version 8, tell me that "you won't accept a patch > > that contains blah" (with "blah" being essential for the patch to work)= . > > Quite the proverbial slap in the face to me. >=20 > I did NOT say that your patch will not be accepted. In one of the > earlier reviews (perhaps even the first) I mentioned that certain > parts should be reviewed separately. It is a slap in the face that > you imply I am a bad person when I repeat that you need to bring up > some issues *separately*. I would consider it bad style from me > towards other developers to change code they might have a strong > opinion on. I don't imply you're a bad person or anything like that, sorry if it seemed so. By the way, I searched the whole thread of "[PATCH] drivemap module" (starting in july 4-20) and the only instances in which "separate", "separately", "split" or similar words are related to phrases like "put the return on a separate line" or "split these declarations" - even though I _do_ remember you telling me something like what you say. I have actually taken the time to re-read all three threads related to drivemap [0][1][2] and the main opposition (from Vesa) was due to what the boot command would do if one of the hooks with abort_on_error set failed and the abort_on_error bit itself. Nothing _fundamental_ about the hook system. The only other objection has surfaced recently (from Robert) and is about the size such system would add to kernel - which mostly depends on the implementation of the hook system (single variable vs. array vs. linked list, for example), not the interface. =20 >=20 > And you can say what you want, but if you are stubborn enough to > ignore what I say in the reviews, you shouldn't be surprised if I > didn't change my opinion in the next review and still ask you to > change something. In fact, it is rude just to send in a new patch > while you did not take the review seriously. There are a lot of > projects that reject patches on beforehand if you didn't at least > bother to get familiar with their coding styles. (kneels on the floor japanese-teen-style) That is true and completely my fault: I was stubbornly trying to convince you to change a big part of the coding style without thinking that conventions are there for a reason. I apologize for all the headaches I may have caused. >=20 > Furthermore, I reviewed your patch mainly because I care, not because > I am the foremost expert in BIOS disks. It's for the best if other > people can look at specific parts of your patch, especially if it > changes the kernel. True, but the list is public and we can't be blamed if others are not interested in parts of the patch. Besides, even though I've shown that the "strong opinions" of Vesa and Robert did not affect any fundamental part of the hook system, I _could_ split it from drivemap and put it up for discussion on a separate thread. >=20 > Perhaps you do not notice how many time I spent on reviewing patches > on this list lately. Anyways, if it is not appreciated, I will leave > the reviews to other people. But I simply will reject all code I do > not like without actually bothering to explain why. I rather spend my > time on coding instead of feeding trolls. It _is_ appreciated: if it weren't for you, this patch would have been lost in the blue long ago, just because no-one would bother to look at it. Besides, if you don't feed the trolls (me?), I'll have to go back to Wikipedia, where my 42 sockpuppets have already been banned! ^^ Seriously, though, I don't mean to be trollish at all, nor to bludgeon others into submission - that's just politics... -Habbit [0] http://lists.gnu.org/archive/html/grub-devel/2008-05/msg00153.html [1] http://lists.gnu.org/archive/html/grub-devel/2008-06/msg00053.html [2] http://lists.gnu.org/archive/html/grub-devel/2008-07/msg00095.html >=20 > -- > Marco >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel --=-r0tDPge5vUsLQMzFj5UC Content-Type: application/pgp-signature; name=signature.asc Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQIVAwUASKSu9aSl+Fbdeo72AQI8Ow/9E48Zg5kgRMxPfiilwecfo3DCJ8co+kOg Ppf9Yu82HJJHHQJOzOhmOsrFdR4kvROSauH3wWr4Vv+8qbepu2MPF3e7psr98+6h g4jeTxKIJciBLrHE7qaTRMQs+1LFbEj9tXNdNIF+eCtqSM2R3mY5zWx+KukSg12j egsN12ICyFXuRi1J2+dthVv938BH4EEnFzg5Roqaic6t3Czmjj6jYSPmcYql5vaN /r5wkyrc9QD8QlgzW6HNIukl+fqeXQ2wQtFFUWy4vh0lv8ingknZzWEKWGZm4vOA Tbe8lcD4NrNfnsEjrQBVqCaPqGXI/AZN/kHMk6Gut7HsP4uoS4l232+faXIqm+fP dmRBz/sBs+UIDRfptO25GiNJmqnLcXOmPGbdt5R0U/nnA7usHcRFEYXqg3aL+qn9 HwCK26ekPr2q5lmvoUV3lSKCuZ7x6roGcpNWfBBZN7AqiNQaQ0L7rHoexlMeSmH2 6rgeckqD38ONCEPXDfH0GM3HgKCkD/IYSjAKnjYVm3khrLXpP4fue0WJxLctlfMb iAsS+dkpeDNHWgT4rNwRM37l/2VTG/vxDCbKDZkgLV6zMhL7eG4aF9MsKVHRlh7p SOT9DXNJr5jVMPcdcJ1dm+xKMkW5kW/uo5sD1fnODPiFT1B6/2SrPDCIc+nycJty GmGoAFKJOI0= =0aUU -----END PGP SIGNATURE----- --=-r0tDPge5vUsLQMzFj5UC--