From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [RFC] Is it okay to just use GNU extensions or should an alternative be provided too?
Date: Sat, 16 Aug 2008 14:43:13 +0200 [thread overview]
Message-ID: <1218890593.5316.6.camel@fz.local> (raw)
In-Reply-To: <48A6C8DC.3050303@nic.fi>
Am Samstag, den 16.08.2008, 15:32 +0300 schrieb Vesa Jääskeläinen:
>
> Please use what ever we have on grub source code already. Then it work
> fine also in standalone grub.
Maybe this time my mail was a bit too short? :)
especially, I ask for asprintf in util/misc.c so just GRUB_UTIL.
But Marco and I thought it would be good to make a general discussion
about GNU extentions.
GCC is needed anyway because of the nested function but what about glibc
or other stuff?
> It should be possible to use existing functions. I see asprintf just a
> wrapper to malloc/sprintf for which there are already versions present
> on grub.
fz@fz:~/grub/grub2.svn$ grep -r asprintf *
util/grub-probe.c: asprintf (&grub_path, "(%s)%s", drive_name, path);
I just discovered that asprintf is indeed already used in the source :)
But yeah maybe there's even in the kernel a use for asprintf,
so maybe a good idea to make a grub_asprintf?
This could be then either always used even if the util/*.c use the
library functions normally or it could be done as with my
grub_print_error change :)
next prev parent reply other threads:[~2008-08-16 12:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-16 12:05 [RFC] Is it okay to just use GNU extensions or should an alternative be provided too? Felix Zielcke
2008-08-16 12:32 ` Vesa Jääskeläinen
2008-08-16 12:39 ` Robert Millan
2008-08-16 12:43 ` Felix Zielcke [this message]
2008-08-16 12:54 ` Vesa Jääskeläinen
2008-08-16 12:58 ` Robert Millan
2008-08-16 12:39 ` Robert Millan
2008-08-16 12:48 ` Felix Zielcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218890593.5316.6.camel@fz.local \
--to=fzielcke@z-51.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.