From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [PATCH] mm: page_remove_rmap comments on PageAnon
Date: Sat, 16 Aug 2008 19:37:50 +0200 [thread overview]
Message-ID: <1218908270.6037.2.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0808152146220.7958@blonde.site>
On Fri, 2008-08-15 at 21:49 +0100, Hugh Dickins wrote:
> Add a comment to s390's page_test_dirty/page_clear_dirty/page_set_dirty
> dance in page_remove_rmap(): I was wrong to think the PageSwapCache test
> could be avoided, and would like a comment in there to remind me. And
> mention s390, to help us remember that this block is not really common.
>
> Also move down the "It would be tidy to reset PageAnon" comment: it does
> not belong to s390's block, and it would be unwise to reset PageAnon
> before we're done with testing it.
Looks fine to me. Thanks Hugh. And if anybody cares:
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-08-16 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 20:49 [PATCH] mm: page_remove_rmap comments on PageAnon Hugh Dickins
2008-08-16 17:37 ` Martin Schwidefsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218908270.6037.2.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.