From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] romfs support for Grub2
Date: Sun, 17 Aug 2008 15:32:50 +0200 [thread overview]
Message-ID: <1218979970.4080.10.camel@fz.local> (raw)
In-Reply-To: <2093CDE06674414C9544AAF40891DAA5@hp2003>
Hello,
Am Sonntag, den 17.08.2008, 21:17 +0800 schrieb y.volta:
> thanks bean, for your suggestion. I'm not famliar with GNU coding, so, would
> you please show me some links to learn? especially the indent style.
I'm not Bean but I can tell you what I was told as I started to
constribute to GRUB
If you send a patch it's always better to make a changelog entry too for
it.
Use the GNU Coding Standards as the manual and existing ChangeLog and
source code as examples :)
First link arethe general GNU Coding Standards, which GRUB has to obey
as a GNU project, so that means you have to obey it too
Second one is a page on the Wiki which is more abotu the GRUB specific
things.
http://www.gnu.org/prep/standards/html_node/index.html
http://grub.enbug.org/CodingStyle
next prev parent reply other threads:[~2008-08-17 13:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48a80c3d.2c012c0a.0a0b.1ed7SMTPIN_ADDED@mx.google.com>
2008-08-17 13:17 ` [PATCH] romfs support for Grub2 y.volta
2008-08-17 13:26 ` Bean
2008-08-17 13:32 ` Felix Zielcke [this message]
2008-08-17 15:36 ` Marco Gerards
[not found] <48a8340b.1e0f2c0a.4d32.2809SMTPIN_ADDED@mx.google.com>
2008-08-17 14:30 ` y.volta
[not found] <48A6FA9A.45473C.07156@m12-70.163.com>
2008-08-17 2:43 ` y.volta
2008-08-17 4:05 ` Bean
2008-08-17 7:09 ` Vesa Jääskeläinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218979970.4080.10.camel@fz.local \
--to=fzielcke@z-51.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.