From: Joe Perches <joe@perches.com>
To: Borislav Petkov <petkovbb@googlemail.com>
Cc: Bartlomiej@gollum.tnic, Zolnierkiewicz@gollum.tnic,
bzolnier@gmail.com, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, Borislav Petkov <petkovbb@gmail.com>
Subject: Re: [PATCH 3/5] ide: add a driver-wide debugging macro
Date: Sun, 17 Aug 2008 11:13:06 -0700 [thread overview]
Message-ID: <1218996786.24527.115.camel@localhost> (raw)
In-Reply-To: <1218993826-4571-4-git-send-email-petkovbb@gmail.com>
On Sun, 2008-08-17 at 19:23 +0200, Borislav Petkov wrote:
> diff --git a/include/linux/ide.h b/include/linux/ide.h
> index c161840..b6d714d 100644
> --- a/include/linux/ide.h
> +++ b/include/linux/ide.h
> []
> +/* DRV_NAME has to be defined in the driver before using the macro below */
> +#define __ide_debug_log(lvl, fmt, args...) \
> +{ \
> + if (unlikely(drive->debug_mask & lvl)) \
> + printk(KERN_INFO DRV_NAME ": " fmt, ## args); \
> +}
Shouldn't a debug printk use KERN_DEBUG?
next prev parent reply other threads:[~2008-08-17 18:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 17:23 [PATCH 0/5] ide debugging macros Borislav Petkov
2008-08-17 17:23 ` Borislav Petkov
2008-08-17 17:23 ` [PATCH 1/5] ide: unify conversion macros Borislav Petkov
2008-08-17 17:23 ` Borislav Petkov
2008-08-17 17:23 ` [PATCH 2/5] ide: add drive->debug_mask switch Borislav Petkov
2008-08-17 17:23 ` Borislav Petkov
2008-08-17 17:23 ` [PATCH 3/5] ide: add a driver-wide debugging macro Borislav Petkov
2008-08-17 17:23 ` Borislav Petkov
2008-08-17 18:13 ` Joe Perches [this message]
2008-08-17 18:24 ` Borislav Petkov
2008-08-17 17:23 ` [PATCH 4/5] ide-floppy: convert driver to the new " Borislav Petkov
2008-08-17 17:23 ` Borislav Petkov
2008-08-17 17:23 ` [PATCH 5/5] ide-floppy: add a debug_mask module parameter Borislav Petkov
2008-08-17 17:23 ` Borislav Petkov
2008-08-18 21:08 ` [PATCH 0/5] ide debugging macros Bartlomiej Zolnierkiewicz
2008-08-18 21:29 ` Bartlomiej Zolnierkiewicz
2008-08-19 6:15 ` Borislav Petkov
2008-08-19 6:23 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218996786.24527.115.camel@localhost \
--to=joe@perches.com \
--cc=Bartlomiej@gollum.tnic \
--cc=Zolnierkiewicz@gollum.tnic \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
--cc=petkovbb@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.