Re: context imbalance false positive sparse warnings

[Harvey Harrison <harvey.harrison@gmail.com>]

On Tue, 2008-08-19 at 17:22 -0500, Steve French wrote:
> On Tue, Aug 19, 2008 at 5:00 PM, Stalin Kenny <stalinlinux@gmail.com> wrote:
> >> Even the simplest use cases throw this error e.g. fs/super.c line 162-164:
> >>
> >> static void put_super(struct super_block *sb)
> >> {
> >>       spin_lock(&sb_lock);
> >>       __put_super(sb);
> >>       spin_unlock(&sb_lock);
> >> }
> >
> > What is the sparse error when you call this function ?
> CHECK   fs/super.c
> fs/super.c:164:2: warning: context imbalance in 'put_super': wrong count at exit
> fs/super.c:164:2:    context 'lock': wanted 0, got 1
> 
> 

Johannes Berg had a 9-patch series that improved this somewhat, but they had
some bugs in them (crashes).  But I've been running with them anyway as they
do improve cases like this significantly.

Harvey