From: Dave Hansen <dave@linux.vnet.ibm.com>
To: arnd@arndb.de
Cc: jeremy@goop.org, containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC v2][PATCH 8/9] Remove some BUG_ON()s that need some proper error handling instead.
Date: Wed, 20 Aug 2008 13:29:46 -0700 [thread overview]
Message-ID: <1219264186.8960.53.camel@nimitz> (raw)
In-Reply-To: <20080820192607.91E0AFF2@nimitz>
On Wed, 2008-08-20 at 12:26 -0700, Dave Hansen wrote:
> diff -puN checkpoint/checkpoint.c~0002-Remove-some-BUG_ON-s-that-need-some-proper-error-ha checkpoint/checkpoint.c
> --- oren-cr.git/checkpoint/checkpoint.c~0002-Remove-some-BUG_ON-s-that-need-some-proper-error-ha 2008-08-20 12:12:51.000000000 -0700
> +++ oren-cr.git-dave/checkpoint/checkpoint.c 2008-08-20 12:12:51.000000000 -0700
> @@ -125,7 +125,8 @@ static int cr_write_tail(struct cr_ctx *
> h.id = 0;
>
> hh->magic = CR_HEADER_MAGIC;
> - hh->cksum[0] = hh->cksum[1] = 1; /* TBD ... */
> + hh->cksum[0] = 1;
> + hh->cksum[1] = 1; /* TBD ... */
>
> ret = cr_write_obj(ctx, &h, hh);
> kfree(hh);
Whoops, that's a bad hunk that belongs in the next patch. Sorry.
-- Dave
next prev parent reply other threads:[~2008-08-20 20:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 19:25 [RFC v2][PATCH 0/9] kernel-based checkpoint-restart Dave Hansen
2008-08-20 19:25 ` [RFC v2][PATCH 1/9] checkpoint-restart: general infrastructure Dave Hansen
2008-08-20 19:25 ` Dave Hansen
2008-08-29 3:34 ` Matt Helsley
2008-08-29 3:34 ` Matt Helsley
2008-08-20 19:25 ` [RFC v2][PATCH 2/9] Remove CAP_SYS_ADMIN for checkpoint/restart Dave Hansen
2008-08-20 19:25 ` Dave Hansen
2008-08-20 19:26 ` [RFC v2][PATCH 3/9] checkpoint/restart: x86 support Dave Hansen
2008-08-20 19:26 ` Dave Hansen
2008-08-20 19:26 ` [RFC v2][PATCH 4/9] checkpoint/restart: memory management Dave Hansen
2008-08-20 19:26 ` Dave Hansen
2008-08-20 19:26 ` [RFC v2][PATCH 5/9] Create trivial sys_checkpoint and sys_restore system calls Dave Hansen
2008-08-20 19:26 ` Dave Hansen
2008-08-20 19:26 ` [RFC v2][PATCH 6/9] Simplify filename handling for now Dave Hansen
2008-08-20 19:26 ` Dave Hansen
2008-08-20 19:26 ` [RFC v2][PATCH 7/9] remove temporary buffer structures Dave Hansen
2008-08-20 19:26 ` Dave Hansen
2008-08-20 19:26 ` [RFC v2][PATCH 8/9] Remove some BUG_ON()s that need some proper error handling instead Dave Hansen
2008-08-20 19:26 ` Dave Hansen
2008-08-20 20:29 ` Dave Hansen
2008-08-20 20:29 ` Dave Hansen [this message]
2008-08-29 4:18 ` Matt Helsley
2008-08-29 4:18 ` Matt Helsley
2008-08-20 19:26 ` [RFC v2][PATCH 9/9] remove ->cksum field Dave Hansen
2008-08-20 19:26 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219264186.8960.53.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=containers@lists.linux-foundation.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.