From: Artem Bityutskiy <dedekind@infradead.org>
To: jaredeh@gmail.com
Cc: Linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org,
linux-mtd <linux-mtd@lists.infradead.org>,
"Jörn Engel" <joern@logfs.org>,
tim.bird@AM.SONY.COM, cotte@de.ibm.com, nickpiggin@yahoo.com.au
Subject: Re: [PATCH 10/10] AXFS: axfs_uncompress.c
Date: Thu, 21 Aug 2008 14:40:38 +0300 [thread overview]
Message-ID: <1219318838.18027.68.camel@sauron> (raw)
In-Reply-To: <48AD0126.1050609@gmail.com>
On Wed, 2008-08-20 at 22:46 -0700, Jared Hulbert wrote:
> + err = zlib_inflateReset(&stream);
> + if (err != Z_OK) {
> + printk(KERN_ERR "zlib_inflateReset error %d\n", err);
> + zlib_inflateEnd(&stream);
> + zlib_inflateInit(&stream);
> + }
Jared,
just FYI, are you aware that LZO which is also present in the kernel is
much faster on decompress than zlib, while its compression is only
slightly worse?
I do not remember the digits, but last time I tested UBIFS, LZO
decompression was about 3 times faster than zlib on OMAP3. This depends
on architecture, etc of course. This may matter a lot if one is fighting
for faster system boot-up. So you might consider supporting LZO as well.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind@infradead.org>
To: jaredeh@gmail.com
Cc: cotte@de.ibm.com, linux-embedded@vger.kernel.org,
nickpiggin@yahoo.com.au, "Jörn Engel" <joern@logfs.org>,
Linux-kernel@vger.kernel.org,
linux-mtd <linux-mtd@lists.infradead.org>,
tim.bird@AM.SONY.COM
Subject: Re: [PATCH 10/10] AXFS: axfs_uncompress.c
Date: Thu, 21 Aug 2008 14:40:38 +0300 [thread overview]
Message-ID: <1219318838.18027.68.camel@sauron> (raw)
In-Reply-To: <48AD0126.1050609@gmail.com>
On Wed, 2008-08-20 at 22:46 -0700, Jared Hulbert wrote:
> + err = zlib_inflateReset(&stream);
> + if (err != Z_OK) {
> + printk(KERN_ERR "zlib_inflateReset error %d\n", err);
> + zlib_inflateEnd(&stream);
> + zlib_inflateInit(&stream);
> + }
Jared,
just FYI, are you aware that LZO which is also present in the kernel is
much faster on decompress than zlib, while its compression is only
slightly worse?
I do not remember the digits, but last time I tested UBIFS, LZO
decompression was about 3 times faster than zlib on OMAP3. This depends
on architecture, etc of course. This may matter a lot if one is fighting
for faster system boot-up. So you might consider supporting LZO as well.
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2008-08-21 11:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 5:46 [PATCH 10/10] AXFS: axfs_uncompress.c Jared Hulbert
2008-08-21 5:46 ` Jared Hulbert
2008-08-21 9:01 ` Sven Wegener
2008-08-21 9:01 ` Sven Wegener
2008-08-21 14:37 ` Jared Hulbert
2008-08-21 14:37 ` Jared Hulbert
2008-08-21 14:53 ` Sven Wegener
2008-08-21 14:53 ` Sven Wegener
2008-08-21 11:40 ` Artem Bityutskiy [this message]
2008-08-21 11:40 ` Artem Bityutskiy
2008-08-21 12:28 ` Geert Uytterhoeven
2008-08-21 12:28 ` Geert Uytterhoeven
2008-08-21 14:35 ` Jared Hulbert
2008-08-21 14:35 ` Jared Hulbert
2008-08-29 13:48 ` Geert Uytterhoeven
2008-08-29 13:48 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219318838.18027.68.camel@sauron \
--to=dedekind@infradead.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=cotte@de.ibm.com \
--cc=jaredeh@gmail.com \
--cc=joern@logfs.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nickpiggin@yahoo.com.au \
--cc=tim.bird@AM.SONY.COM \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.