From: Daniel Walker <dwalker@mvista.com>
To: jaredeh@gmail.com
Cc: Linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org,
linux-mtd <linux-mtd@lists.infradead.org>,
"Jörn Engel" <joern@logfs.org>,
tim.bird@AM.SONY.COM, cotte@de.ibm.com, nickpiggin@yahoo.com.au
Subject: Re: [PATCH 03/10] AXFS: axfs.h
Date: Thu, 21 Aug 2008 06:10:58 -0700 [thread overview]
Message-ID: <1219324258.23311.14.camel@localhost.localdomain> (raw)
In-Reply-To: <48AD00E6.2070505@gmail.com>
On Wed, 2008-08-20 at 22:45 -0700, Jared Hulbert wrote:
> +#define AXFS_GET_BYTETABLE_VAL(desc,index) \
> + axfs_bytetable_stitch(((struct
> axfs_region_desc)(desc)).table_byte_depth,\
> + (u8 *)((struct axfs_region_desc)(desc)).virt_addr, index)
> +
> +#define AXFS_GET_NODE_TYPE(sbi,node_index) \
> + AXFS_GET_BYTETABLE_VAL(((struct axfs_super *)(sbi))->node_type,\
> + (node_index))
> +
> +#define AXFS_GET_NODE_INDEX(sbi,node__index) \
> + AXFS_GET_BYTETABLE_VAL(((struct axfs_super *)(sbi))->node_index,\
> + (node__index))
> +
I think it would be much cleaner to do all these similar macro's as
static inline functions.
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Walker <dwalker@mvista.com>
To: jaredeh@gmail.com
Cc: cotte@de.ibm.com, linux-embedded@vger.kernel.org,
nickpiggin@yahoo.com.au, "Jörn Engel" <joern@logfs.org>,
Linux-kernel@vger.kernel.org,
linux-mtd <linux-mtd@lists.infradead.org>,
tim.bird@AM.SONY.COM
Subject: Re: [PATCH 03/10] AXFS: axfs.h
Date: Thu, 21 Aug 2008 06:10:58 -0700 [thread overview]
Message-ID: <1219324258.23311.14.camel@localhost.localdomain> (raw)
In-Reply-To: <48AD00E6.2070505@gmail.com>
On Wed, 2008-08-20 at 22:45 -0700, Jared Hulbert wrote:
> +#define AXFS_GET_BYTETABLE_VAL(desc,index) \
> + axfs_bytetable_stitch(((struct
> axfs_region_desc)(desc)).table_byte_depth,\
> + (u8 *)((struct axfs_region_desc)(desc)).virt_addr, index)
> +
> +#define AXFS_GET_NODE_TYPE(sbi,node_index) \
> + AXFS_GET_BYTETABLE_VAL(((struct axfs_super *)(sbi))->node_type,\
> + (node_index))
> +
> +#define AXFS_GET_NODE_INDEX(sbi,node__index) \
> + AXFS_GET_BYTETABLE_VAL(((struct axfs_super *)(sbi))->node_index,\
> + (node__index))
> +
I think it would be much cleaner to do all these similar macro's as
static inline functions.
Daniel
next prev parent reply other threads:[~2008-08-21 13:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 5:45 [PATCH 03/10] AXFS: axfs.h Jared Hulbert
2008-08-21 5:45 ` Jared Hulbert
2008-08-21 7:51 ` Carsten Otte
2008-08-21 7:51 ` Carsten Otte
2008-08-21 11:31 ` Arnd Bergmann
2008-08-21 11:31 ` Arnd Bergmann
2008-08-21 20:05 ` Jared Hulbert
2008-08-21 20:05 ` Jared Hulbert
2008-08-21 12:24 ` Arnd Bergmann
2008-08-21 12:24 ` Arnd Bergmann
2008-08-21 22:40 ` Jared Hulbert
2008-08-21 22:40 ` Jared Hulbert
2008-08-22 11:27 ` Arnd Bergmann
2008-08-22 11:27 ` Arnd Bergmann
2008-08-22 12:04 ` Geert Uytterhoeven
2008-08-22 12:04 ` Geert Uytterhoeven
2008-08-22 12:04 ` Geert Uytterhoeven
2008-08-22 18:12 ` Jared Hulbert
2008-08-22 18:12 ` Jared Hulbert
2008-08-21 13:10 ` Daniel Walker [this message]
2008-08-21 13:10 ` Daniel Walker
2008-08-21 20:07 ` Jared Hulbert
2008-08-21 20:07 ` Jared Hulbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219324258.23311.14.camel@localhost.localdomain \
--to=dwalker@mvista.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=cotte@de.ibm.com \
--cc=jaredeh@gmail.com \
--cc=joern@logfs.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nickpiggin@yahoo.com.au \
--cc=tim.bird@AM.SONY.COM \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.