From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KWAGV-0007QY-S5
	for mharc-grub-devel@gnu.org; Thu, 21 Aug 2008 09:31:51 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KWAGU-0007P4-2p
	for grub-devel@gnu.org; Thu, 21 Aug 2008 09:31:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KWAGS-0007NR-H1
	for grub-devel@gnu.org; Thu, 21 Aug 2008 09:31:49 -0400
Received: from [199.232.76.173] (port=37151 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KWAGS-0007ND-7G
	for grub-devel@gnu.org; Thu, 21 Aug 2008 09:31:48 -0400
Received: from moutng.kundenserver.de ([212.227.126.188]:57332)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fzielcke@z-51.de>) id 1KWAGR-0007PW-PN
	for grub-devel@gnu.org; Thu, 21 Aug 2008 09:31:48 -0400
Received: from [85.180.32.198] (e180032198.adsl.alicedsl.de [85.180.32.198])
	by mrelayeu.kundenserver.de (node=mrelayeu3) with ESMTP (Nemesis)
	id 0MKxQS-1KWAGQ1IxU-0000Mp; Thu, 21 Aug 2008 15:31:46 +0200
From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
In-Reply-To: <20080821131422.GA15592@thorin>
References: <1219266086.4903.37.camel@fz.local> <20080821131422.GA15592@thorin>
Content-Type: text/plain
Date: Thu, 21 Aug 2008 15:31:45 +0200
Message-Id: <1219325505.4090.27.camel@fz.local>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 
Content-Transfer-Encoding: 7bit
X-Provags-ID: V01U2FsdGVkX18RNcowg0O69WMoWNGByA4ZvrdA5XDnUYx45R6
	PyCiToe7u2e1hHrGDQiPyWQitcBAOUUFlAaYs1YZhBlK1+yZYp
	elzpl3QXeyJQOHKT5RsW2+pJ2N+pWib
X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!)
Subject: Re: [PATCH] fix for a memleak in grub_ntfs_mount
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Aug 2008 13:31:50 -0000

Commited.
(Copyright of fs/ntfs.c has 2008 and Changelog has \t :))

Hopefully I can find out more about the other complains from valgrind.

Am Donnerstag, den 21.08.2008, 15:14 +0200 schrieb Robert Millan:
> On Wed, Aug 20, 2008 at 11:01:26PM +0200, Felix Zielcke wrote:
> > 2008-08-20  Felix Zielcke  <fzielcke@z-51.de>
> > 
> > 	* fs/ntfs.c (grub_ntfs_mount): Fix a memory leak. 
> > 
> > Index: fs/ntfs.c
> > ===================================================================
> > --- fs/ntfs.c	(Revision 1822)
> > +++ fs/ntfs.c	(Arbeitskopie)
> > @@ -850,6 +850,7 @@ fail:
> >      {
> >        free_file (&data->mmft);
> >        free_file (&data->cmft);
> > +      grub_free (data);
> >      }
> >    return 0;
> >  }
> 
> Looks fine to me.
>