From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: akpm@linux-foundation.org, linux-scsi@vger.kernel.org,
stefanr@s5r6.in-berlin.de
Subject: Re: [patch 17/18] scsi: select CRC_T10DIF only when necessary
Date: Thu, 21 Aug 2008 09:19:56 -0500 [thread overview]
Message-ID: <1219328396.3265.4.camel@localhost.localdomain> (raw)
In-Reply-To: <yq1vdxuzcum.fsf@sermon.lab.mkp.net>
On Thu, 2008-08-21 at 10:01 -0400, Martin K. Petersen wrote:
> - select CRC_T10DIF
> + select CRC_T10DIF if BLK_DEV_INTEGRITY
>
> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Actually, I don't think this is right at all.
This is a purely cosmetic fix and the tip of the iceberg. If not
compiling in the integrity code matters on grounds of kernel bloat, and
I think it does, then the correct fix is to make sure none of it
compiles into SD if BLK_DEV_INTEGRITY isn't set.
James
next prev parent reply other threads:[~2008-08-21 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 23:55 [patch 17/18] scsi: select CRC_T10DIF only when necessary akpm
2008-08-21 14:01 ` Martin K. Petersen
2008-08-21 14:19 ` James Bottomley [this message]
2008-08-21 14:49 ` Martin K. Petersen
2008-08-21 15:07 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219328396.3265.4.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.