From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754884AbYHYKc6 (ORCPT ); Mon, 25 Aug 2008 06:32:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753467AbYHYKcu (ORCPT ); Mon, 25 Aug 2008 06:32:50 -0400 Received: from casper.infradead.org ([85.118.1.10]:43066 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753157AbYHYKct (ORCPT ); Mon, 25 Aug 2008 06:32:49 -0400 Subject: Re: [PATCH 2/2] smp_call_function: use rwlocks on queues rather than rcu From: Peter Zijlstra To: paulmck@linux.vnet.ibm.com Cc: Christoph Lameter , Pekka Enberg , Ingo Molnar , Jeremy Fitzhardinge , Nick Piggin , Andi Kleen , "Pallipadi, Venkatesh" , Suresh Siddha , Jens Axboe , Rusty Russell , Linux Kernel Mailing List In-Reply-To: <20080822205339.GK6744@linux.vnet.ibm.com> References: <48AE0883.6050701@goop.org> <20080822062800.GQ14110@elte.hu> <84144f020808220006n25d684b1n9db306ddc4f58c4c@mail.gmail.com> <48AEC6B2.1080701@linux-foundation.org> <20080822151156.GA6744@linux.vnet.ibm.com> <48AEF3FD.70906@linux-foundation.org> <20080822182915.GG6744@linux.vnet.ibm.com> <48AF0735.60402@linux-foundation.org> <20080822195226.GJ6744@linux.vnet.ibm.com> <48AF1B81.3050806@linux-foundation.org> <20080822205339.GK6744@linux.vnet.ibm.com> Content-Type: text/plain Date: Mon, 25 Aug 2008 12:31:31 +0200 Message-Id: <1219660291.8515.20.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2008-08-22 at 13:53 -0700, Paul E. McKenney wrote: > On Fri, Aug 22, 2008 at 03:03:13PM -0500, Christoph Lameter wrote: > > Paul E. McKenney wrote: > > > > > I was indeed thinking in terms of the free from RCU being specially marked. > > > > Isnt there some way to shorten the rcu periods significantly? Critical > > sections do not take that long after all. > > In theory, yes. However, the shorter the grace period, the greater the > per-update overhead of grace-period detection -- the general approach > is to use a per-CPU high-resolution timer to force RCU grace period > processing every 100 microseconds or so. You could of course also drive the rcu state machine from rcu_read_unlock(). > Also, by definition, the RCU > grace period can be no shorter than the longest active RCU read-side > critical section. Nevertheless, I have designed my current hierarchical > RCU patch with expedited grace periods in mind, though more for the > purpose of reducing latency of long strings of operations that involve > synchronize_rcu() than for cache locality. Another thing that could be done is more often force a grace period by flipping the counters.