From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Date: Tue, 26 Aug 2008 15:44:40 +0000 Subject: RE: [PATCH 2/4] add e500 tlb implementation Message-Id: <1219765480.10621.5.camel@localhost.localdomain> List-Id: References: <1218790228-19549-3-git-send-email-yu.liu@freescale.com> In-Reply-To: <1218790228-19549-3-git-send-email-yu.liu@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On Fri, 2008-08-22 at 17:10 +0800, Liu Yu wrote: > > I also missed Hollis's "down_read" patch. > Btw: since 44x change it to down_read here, why 44x still use > down_write in other places? I think you're referring to kvmppc_mmu_invalidate() and kvmppc_mmu_priv_switch(). I had the locking in there because I thought that it was needed around kvmppc_44x_shadow_release() (which ends up becoming put_page()). However, judging from the x86 code I don't think that's accurate, so I should remove that locking. -- Hollis Blanchard IBM Linux Technology Center