From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KYfcu-0005fS-8B for mharc-grub-devel@gnu.org; Thu, 28 Aug 2008 07:25:20 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KYfcr-0005fK-Fm for grub-devel@gnu.org; Thu, 28 Aug 2008 07:25:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KYfco-0005dn-23 for grub-devel@gnu.org; Thu, 28 Aug 2008 07:25:17 -0400 Received: from [199.232.76.173] (port=52545 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KYfcn-0005df-Q3 for grub-devel@gnu.org; Thu, 28 Aug 2008 07:25:13 -0400 Received: from moutng.kundenserver.de ([212.227.126.188]:49381) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KYfcn-0000Pp-Bh for grub-devel@gnu.org; Thu, 28 Aug 2008 07:25:13 -0400 Received: from [85.180.50.80] (e180050080.adsl.alicedsl.de [85.180.50.80]) by mrelayeu.kundenserver.de (node=mrelayeu3) with ESMTP (Nemesis) id 0MKxQS-1KYfcl42RG-0000m0; Thu, 28 Aug 2008 13:25:12 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20080828111405.GD8224@gagh.ehv.newtec.eu> References: <20080828111405.GD8224@gagh.ehv.newtec.eu> Content-Type: text/plain Date: Thu, 28 Aug 2008 13:25:11 +0200 Message-Id: <1219922711.4598.49.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1+zjLEzIVtTY57YZ1Kb7Cy/iBqO5f9i6s84s2D PCgeQ3RiMEsTxYu0UeyX2GbtU3hgxEK17TyoSEoL+1+76NtYOD uDtkP7bcuiEpXmtV9xkt6GoUz5V+XhX X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) Cc: Jan Derk Gerlings Subject: Re: grub 1.96 svn 20080813 and circular lvm2 metadata X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2008 11:25:18 -0000 Am Donnerstag, den 28.08.2008, 13:14 +0200 schrieb Hans Lambermont: > Hi all, Hello, > My colleague Jan Derk Gerlings found a bug in the way grub 1.96, svn > version 20080813 (and earlier) reads the circular lvm2 metadata buffer. Great, on Debian BTS we have 2 bugs [0] related to LVM and I wasn't able yet to trace them down, but that could be the reason for them. > Shall we attempt to fix this and send a patch ? Yes please do :) Because GRUB is a GNU project, you have to obey the GNU Coding Standards [1] The Maintainer standards [2] says that on ~15 line changes you need to assign copyright to FSF, but for this the others can tell you more after you did your patch. So just try to obey the coding style used in GRUB and please try to write a changelog entry, see GCS as a manual and the changelog file for examples [0] http://bugs.debian.org/462835 http://bugs.debian.org/495949 [1] http://www.gnu.org/prep/standards/html_node/index.html [2] http://www.gnu.org/prep/maintain/maintain.html#Legally-Significant -- Felix Zielcke