From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KZ0Kp-0000iD-WA for mharc-grub-devel@gnu.org; Fri, 29 Aug 2008 05:32:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZ0Km-0000gj-Ja for grub-devel@gnu.org; Fri, 29 Aug 2008 05:32:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZ0Kk-0000fl-Q9 for grub-devel@gnu.org; Fri, 29 Aug 2008 05:31:59 -0400 Received: from [199.232.76.173] (port=40551 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZ0Kk-0000fN-9U for grub-devel@gnu.org; Fri, 29 Aug 2008 05:31:58 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:54781) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KZ0Kj-0002wl-Hs for grub-devel@gnu.org; Fri, 29 Aug 2008 05:31:57 -0400 Received: from [85.180.43.60] (e180043060.adsl.alicedsl.de [85.180.43.60]) by mrelayeu.kundenserver.de (node=mrelayeu7) with ESMTP (Nemesis) id 0ML2xA-1KZ0Kh1Bcy-0003HZ; Fri, 29 Aug 2008 11:31:55 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20080829090019.GA6721@gagh.ehv.newtec.eu> References: <20080828111405.GD8224@gagh.ehv.newtec.eu> <1219922711.4598.49.camel@fz.local> <20080829090019.GA6721@gagh.ehv.newtec.eu> Content-Type: text/plain Date: Fri, 29 Aug 2008 11:31:54 +0200 Message-Id: <1220002314.7292.53.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1+Uw2HmZqX/vnfuiTXeQTNXdIvi3UTRL5CnTRj tADMfhIWWLSpqrn5er7EdFYGukQnG266CTXUYqMozuJ8EXYlMb AoIrg+Fp0kEb3PPLgTuEYOq7g1AEXIQ X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) Cc: Jan Derk Gerlings Subject: Re: grub 1.96 svn 20080813 and circular lvm2 metadata X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2008 09:32:01 -0000 Am Freitag, den 29.08.2008, 11:00 +0200 schrieb Hans Lambermont: > Please find the patch attached, this was tested with circular metadata > and the segfault in grub-setup is gone and the system boots fine. I just forwarded it now to the reporters of these 2 Debian bugs I mentioned. I hope they try it out soon and reply if it helps for them. Thanks again to your colleague and you. > > Because GRUB is a GNU project, you have to obey the GNU Coding Standards [1] > > Ok, I hope I got it right. If not please let me know. Oh it seems I forgot you to tell you 2 things ;) The Changelog entry should be seperate, i.e. not a diff against the actual ChangeLog file but you can have it above inside your patch For example here my last small patch send to the list http://lists.gnu.org/archive/html/grub-devel/2008-08/txtUBorY42rw2.txt Second please use `svn diff --diff-cmd diff -x -up' so the C function name is printed inside the diff. 2008-08-28 Hans Lambermont (tiny change) Yep, GCS mentions this `tiny change' but it's never used in GRUB's ChangeLog. + metadatabuf = grub_malloc (2*mda_size); should be (2 * mda_size) + grub_memcpy(metadatabuf + mda_size, metadatabuf + mdah->start, again another space missing Except of this it looks fine for me, but I just started to contribute to GRUB and in fact my C experience isn't that great either. And I only started to use LVM for bugs in GRUB. No need to send another patch just for these little changes, better just wait a few days for comments from the others and if nobody replies then feel free to bring it up again with a 2nd patch :) -- Felix Zielcke