From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KZ5nj-0002Mk-0r for mharc-grub-devel@gnu.org; Fri, 29 Aug 2008 11:22:15 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZ5nh-0002MB-Mb for grub-devel@gnu.org; Fri, 29 Aug 2008 11:22:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZ5ne-0002Kt-2u for grub-devel@gnu.org; Fri, 29 Aug 2008 11:22:13 -0400 Received: from [199.232.76.173] (port=47122 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZ5nd-0002Km-Pn for grub-devel@gnu.org; Fri, 29 Aug 2008 11:22:09 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:61012) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KZ5nd-0006Hh-Ct for grub-devel@gnu.org; Fri, 29 Aug 2008 11:22:10 -0400 Received: from [85.180.44.204] (e180044204.adsl.alicedsl.de [85.180.44.204]) by mrelayeu.kundenserver.de (node=mrelayeu8) with ESMTP (Nemesis) id 0ML31I-1KZ5na48tL-0002LC; Fri, 29 Aug 2008 17:22:07 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <48B80F04.2030702@nic.fi> References: <20080828111405.GD8224@gagh.ehv.newtec.eu> <1219922711.4598.49.camel@fz.local> <20080829090019.GA6721@gagh.ehv.newtec.eu> <1220002314.7292.53.camel@fz.local> <48B80F04.2030702@nic.fi> Content-Type: text/plain; charset=UTF-8 Date: Fri, 29 Aug 2008 17:22:06 +0200 Message-Id: <1220023326.4519.22.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V01U2FsdGVkX18ZKpiRQ6lM6Xv5i8DgAOVJ+GOQh5scm9cmjGZ Dl3AynnWuBlRoReADiMY9awPAFHTfLFdNgH7RiiAbihzZxU7/t VshSVxl08iHswqkgp+0zPs4vBXDBcNN X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) Subject: Re: grub 1.96 svn 20080813 and circular lvm2 metadata X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2008 15:22:14 -0000 Hello, Am Freitag, den 29.08.2008, 18:00 +0300 schrieb Vesa J=C3=A4=C3=A4skel=C3= =A4inen: > Felix Zielcke wrote: > > The Changelog entry should be seperate, i.e. not a diff against the > > actual ChangeLog file but you can have it above inside your patch > > For example here my last small patch send to the list >=20 > That is perfectly fine there :) >=20 > Thou, you can also copy it within your email too. But everyone can spot > it from patch too. Most important aspect is that it has to be there... Right ;) I think that in general it's just better to not make an actual diff against it, but I failed to tell him. So it's anyway my fault again :) Hm but now that I think about it, the `ChangeLog' file will probable be mostly first on the diffs' After a few days it just can't be applies cleanly but for the ChangeLog entry you anyway need to copy and modify it first before commiting :)