From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KZPh1-00033z-AX for mharc-grub-devel@gnu.org; Sat, 30 Aug 2008 08:36:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZPgz-00031f-AJ for grub-devel@gnu.org; Sat, 30 Aug 2008 08:36:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZPgx-0002zU-SN for grub-devel@gnu.org; Sat, 30 Aug 2008 08:36:37 -0400 Received: from [199.232.76.173] (port=39754 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZPgx-0002zN-PE for grub-devel@gnu.org; Sat, 30 Aug 2008 08:36:35 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:49667) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KZPgx-00058K-9O for grub-devel@gnu.org; Sat, 30 Aug 2008 08:36:35 -0400 Received: from [85.180.38.25] (e180038025.adsl.alicedsl.de [85.180.38.25]) by mrelayeu.kundenserver.de (node=mrelayeu5) with ESMTP (Nemesis) id 0ML25U-1KZPgv2neH-0005x7; Sat, 30 Aug 2008 14:36:33 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20080830120153.GG16775@thorin> References: <1219943377.4598.56.camel@fz.local> <20080830120153.GG16775@thorin> Content-Type: text/plain Date: Sat, 30 Aug 2008 14:36:32 +0200 Message-Id: <1220099792.21696.9.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1+QvBaKiYf48U3xL9jJC3E6gRxNx+SDLcrFxGI 2S0uTlMP8AdkxhNjR1BiZsrIGjjgT1nN0a5gE5c1tWNlT+ell4 fXVSdARilzLCs78vERAwtq4SmbR3tzs X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) Subject: Re: [PATCH] new static const char[] modname X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Aug 2008 12:36:37 -0000 Am Samstag, den 30.08.2008, 14:01 +0200 schrieb Robert Millan: > I think the idea with this was to unify the strings for grub_dprintf calls; > your patch goes a bit further and also puts other sort of strings to share > the same variable. > > I think that's a bit dangerous, since changes intended for one use of the > variable could collaterally affect the rest in subtle ways. And it's not > that useful in code size anyway. Oh right, but then modname seems to be a bit the wrong name, if it should ony be used for grub_dprintf. For example the i386-pc biosdisc.c uses grub_dprintf("disk") and partmap/pc.c uses "partition" What about moddebugname or something like that then? -- Felix Zielcke