From: Liam Girdwood <lrg@kernel.org>
To: Alan Horstmann <gineera@aspect135.co.uk>
Cc: Bryan Wu <cooloney@kernel.org>, Cliff Cai <cliff.cai@analog.com>,
alsa-devel@alsa-project.org, liam.girdwood@wolfsonmicro.com,
broonie@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 3/4] ASOC: WM8731 codec: add SPI support as well as I2C
Date: Mon, 01 Sep 2008 15:00:16 +0100 [thread overview]
Message-ID: <1220277616.6499.119.camel@odin> (raw)
In-Reply-To: <200809011452.08070.gineera@aspect135.co.uk>
On Mon, 2008-09-01 at 14:52 +0100, Alan Horstmann wrote:
> We have just started trying this out as an alternative to i2c, and picked out
> the following:
>
> On Wednesday 27 August 2008 10:39, Bryan Wu wrote:
> > -#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
> > +#if defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE) && !defined
> > (CONFIG_SND_SOC_WM8731_SPI)
>
> I think this needs extra brackets round the ||'s before the && thus:
>
> > +#if (defined (CONFIG_I2C) || defined (CONFIG_I2C_MODULE)) && !defined
> > (CONFIG_SND_SOC_WM8731_SPI)
>
> in order to force use of SPI when (CONFIG_SND_SOC_WM8731_SPI) and (CONFIG_I2C)
> are both defined. Or have we misunderstood the intention? This is in 2
> other places also in the patch.
>
It may be simpler to only have CONFIG_SND_SOC_WM8731_SPI and
CONFIG_SND_SOC_WM8731_I2C definitions for all the codec drivers. These
would be set by machine Kconfig.
Liam
next prev parent reply other threads:[~2008-09-01 14:00 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 9:39 [PATCH 0/4] Blackfin supports for ALSA/ASOC Bryan Wu
2008-08-27 9:39 ` [PATCH 1/4] ASOC: Blackfin driver for ALSA SoC framework Bryan Wu
2008-08-27 13:48 ` Mark Brown
2008-08-27 13:48 ` Mark Brown
2008-09-03 4:09 ` Cai, Cliff
2008-09-03 4:09 ` Cai, Cliff
2008-09-03 10:38 ` Mark Brown
2008-09-03 10:38 ` Mark Brown
2008-09-04 3:54 ` [alsa-devel] " Cliff Cai
2008-09-04 3:54 ` Cliff Cai
2008-08-27 9:39 ` [PATCH 2/4] ASOC codec: add support for SSM2602 audio codec in " Bryan Wu
2008-08-27 9:39 ` Bryan Wu
2008-08-27 10:54 ` Mark Brown
2008-08-27 10:54 ` [alsa-devel] " Mark Brown
2008-08-28 5:55 ` Bryan Wu
2008-08-28 5:55 ` [alsa-devel] " Bryan Wu
2008-08-28 10:06 ` Mark Brown
2008-08-28 11:44 ` Jean Delvare
2008-08-28 11:44 ` [alsa-devel] " Jean Delvare
2008-08-27 9:39 ` [PATCH 3/4] ASOC: WM8731 codec: add SPI support as well as I2C Bryan Wu
2008-08-27 9:39 ` Bryan Wu
2008-08-27 11:01 ` Mark Brown
2008-08-27 11:01 ` [alsa-devel] " Mark Brown
2008-08-28 3:46 ` Bryan Wu
2008-08-28 3:46 ` [alsa-devel] " Bryan Wu
2008-08-28 10:14 ` Mark Brown
2008-08-28 10:14 ` [alsa-devel] " Mark Brown
2008-08-28 12:47 ` Takashi Iwai
2008-08-28 12:47 ` [alsa-devel] " Takashi Iwai
2008-08-28 13:01 ` Mark Brown
2008-08-28 13:01 ` [alsa-devel] " Mark Brown
2008-09-01 13:52 ` Alan Horstmann
2008-09-01 13:52 ` [alsa-devel] " Alan Horstmann
2008-09-01 14:00 ` Liam Girdwood [this message]
2008-09-01 14:02 ` Mark Brown
2008-09-01 14:02 ` [alsa-devel] " Mark Brown
2008-09-02 10:22 ` Alan Horstmann
2008-09-02 12:27 ` Mark Brown
2008-08-27 9:39 ` [PATCH 4/4] ALSA: add dummy function to support shared mmap in nommu Blackfin arch Bryan Wu
2008-08-27 9:39 ` Bryan Wu
2008-08-28 12:44 ` Takashi Iwai
2008-08-28 12:44 ` Takashi Iwai
2008-09-02 3:16 ` Cai, Cliff
2008-09-02 3:16 ` Cai, Cliff
2008-09-02 9:41 ` Takashi Iwai
2008-09-02 9:41 ` Takashi Iwai
2008-09-02 9:59 ` Bryan Wu
2008-09-02 9:59 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220277616.6499.119.camel@odin \
--to=lrg@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cliff.cai@analog.com \
--cc=cooloney@kernel.org \
--cc=gineera@aspect135.co.uk \
--cc=liam.girdwood@wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.