From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Kagal-000081-9Z for mharc-grub-devel@gnu.org; Tue, 02 Sep 2008 20:51:27 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kagaj-00006i-Pt for grub-devel@gnu.org; Tue, 02 Sep 2008 20:51:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kagai-00005T-JR for grub-devel@gnu.org; Tue, 02 Sep 2008 20:51:25 -0400 Received: from [199.232.76.173] (port=46292 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kagai-00005O-At for grub-devel@gnu.org; Tue, 02 Sep 2008 20:51:24 -0400 Received: from ug-out-1314.google.com ([66.249.92.168]:21346) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kagah-00051L-Pm for grub-devel@gnu.org; Tue, 02 Sep 2008 20:51:24 -0400 Received: by ug-out-1314.google.com with SMTP id m2so2383287uge.17 for ; Tue, 02 Sep 2008 17:51:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer; bh=ihMN5cIPImhG0Uc+fpb8O76UfKr+2fYdWMTp1cOGsTg=; b=sfz3cbf4CTltCOwK4j8LoxDQU8VPBGcYIYVbt2DQGb0vXmvzl2Urbo/cO9bYCKxTiu ZR1HkkEuud8fsVZoKrboa+b8IDNslCfHIHIm7v2SYAH/LuoHR2v7ZfP2sO+QOo8w/FhH Iu703Z3mgAI9YUwwKPLQtHUWhCt2lWZolYV4s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer; b=a6fh5NGJ47yO+bilbpkmZEqT8ghRgcXIjh09ipVEMoo/1d3mavkAGVmg1UT/R7q8Rb MsNmg71F+aKoGHU3HNUSkAna1Og9yuVaOT5+ANXb6VIrheVlwVUm/w2wMGuwqks3gC6K b3vzV1gn/H8S88VY0X56mz21Rk8c5CRzgyiSs= Received: by 10.66.224.19 with SMTP id w19mr4559427ugg.72.1220403081015; Tue, 02 Sep 2008 17:51:21 -0700 (PDT) Received: from ?192.168.1.100? ( [213.37.137.93]) by mx.google.com with ESMTPS id o7sm5590799uge.6.2008.09.02.17.51.18 (version=SSLv3 cipher=RC4-MD5); Tue, 02 Sep 2008 17:51:20 -0700 (PDT) From: Javier =?ISO-8859-1?Q?Mart=EDn?= To: The development of GRUB 2 In-Reply-To: <48BDD573.5010809@gmail.com> References: <48BD4C52.6040308@gmail.com> <1220367299.23879.15.camel@localhost> <48BD62BE.7090507@gmail.com> <1220373059.23879.25.camel@localhost> <48BD8847.9030502@gmail.com> <1220386216.23879.55.camel@localhost> <48BDBC96.3010602@gmail.com> <1220398682.23879.70.camel@localhost> <48BDD573.5010809@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-FBCjHK8BqjQYS35FgFYB" Date: Wed, 03 Sep 2008 02:54:14 +0200 Message-Id: <1220403254.23879.81.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: Sendkey patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2008 00:51:26 -0000 --=-FBCjHK8BqjQYS35FgFYB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable El mi=C3=A9, 03-09-2008 a las 02:08 +0200, phcoder escribi=C3=B3: > Hello, again. > Javier Mart=C3=ADn wrote: > > We have 63 sectors =3D 32256 bytes (sectors range from 0 to 63 and the > > first is used by the MBR). > >=20 > I've just rechecked on my system. My first partition begins at sector > number 63. This is the value I've seen at most systems. So last usable > sector is 62. Sector 0 is MBR. So we have 62 sectors Oops, true! How strange. So there was no sector 63 in the CHS model and that is why the first sector of cyl 1 (the start of the first partition) is LBA 63... Does anyone know the historical reasons for this? > >> And now our core image (my version > >> with error reporting) with ata,pc and reiserfs is 29654 bytes. This > >> leaves us 2090 bytes. This combination is not something completely out > >> of the ordinary. So I suggest to give the priority to the size of the > >> kernel over readability (perhaps adding some comments to my version). > > I was wondering why my data did not match yours, and then I realized I > > was using my usual "extreme" combination of modules: "biosdisk pc ext2 > > lvm raid" yields 29298 bytes, "plenty" of space. But ata and reiserfs > > are quite the bloaters... The reiserfs case is particularly strange: in > > the linux kernel, the reiserfs module is 50% bigger than ext3.ko; while > > in GRUB, reiserfs.mod (without journaling) is twice the size of ext2.mo= d > > (which includes full support for ext2, partial journal support in ext3 > > and extents in ext4). > >=20 > I'll have a look at it but not sure to find anything since I'm not > familiar with either ata or reiserfs internal structure. I was not suggesting that it was you or me who did it; it was a general "call" for GRUB devs... (ahem xD) > > Thus, while you are right in prioritizing kernel size; why not optimize > > reiserfs a bit instead of killing our (and future maintainers') eyes an= d > > brains to shave less than 40 bytes from kernel? I suppose the story > > would be similar with ata, because it is a new module that is yet in > > development. > Well the point is that if we don't do it now and then one day we'll have > to squeeze the core it will be very difficult to find places like this. Yes, but my point is that 40 bytes is so small a difference that it can offset by simply rewriting error strings in kernel and other smallish non-intrusive changes and thus we should prioritize future maintainability. However, eventually this is not our decision to make: the Overlords here (mainly Marco, but also Robert, Vesa and Bean) are the ones who should, likely only once the interface is established, decide how to conjugate the Prime Directive of "keep kernel small" with code complexity in this particular case. -Habbit --=-FBCjHK8BqjQYS35FgFYB Content-Type: application/pgp-signature; name=signature.asc Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQIVAwUASL3gNaSl+Fbdeo72AQIx1RAAhQBo6ekKrWsee+WBpJUuVKLX9+Di/Py7 QAa5vdAiM/IObZISKXb1v3bk5rzvIKRMN4iW1BzPXRoLfQsomlyJNC6B9Xy0d/YS cptrDrD5ebufnr/gGpY2yhG22iNo6mkrmEYjqPEmM7g/RBznRIjxwws//vjA1owF zk4JPOLF4PwG90M52BjJh8RxmExB4hu6UtO0doROUkF+RoQxuL2vCb7hoa/1fZJ9 xVYfGPfffPe/OPRMu7pDIlXbLcHNIVTOHk0Nbu92U4g3rfW4JjJAWJQCm7Aoxsjl VwyYDKAblXrXul6nHaGJygVO8GbI7sYdowXwvKssZlj5wg8fiDUPMPCECtmQW0NT aI6r5hQuXFYCNAdWljmDcQ3yiVCqIt9CmBVPif/wJJQ0VBJhmITWIbCa1VGluhuW Z1OV2JrwNZqsalCz4Dy5f/DdrrxTnQcOaLyC+xYbAsDJwQXhJ+536aKy86ch8Ygd NARIQ3NRE1Lr/GYaG4bKQ0tWQ8XDe80ngObLuCjWY9hSOegz2sU0FPTgHtpDB+fB tAdXN6/p7gPWLUkiDLLzl5/19WIo2OsKY57aphEi3uRfEy8k5bkXP6WKBfKXkpWz H5ZHEnCHABGzEmdKvdUBkHnDB+s00RVfyoqSP/OTN3Nl/UBEIHIsGX3jgdk6/YLc Vw2EUVMiBYo= =JKfU -----END PGP SIGNATURE----- --=-FBCjHK8BqjQYS35FgFYB--