From: "stanley.miao" <stanley.miao@windriver.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP3: Fix omapfb's problem on OMAP3430sdp
Date: Wed, 03 Sep 2008 09:53:16 +0800 [thread overview]
Message-ID: <1220406796.7042.34.camel@localhost> (raw)
In-Reply-To: <200809020751.48357.david-b@pacbell.net>
On Tue, 2008-09-02 at 07:51 -0700, David Brownell wrote:
> On Monday 01 September 2008, stanley.miao wrote:
> > + if(!is_sil_rev_less_than(OMAP3430_REV_ES2_0)) {
>
> But checkpatch.pl rejected that, yes? Fixed in a later
> version I see.
It has been fixed in a later version.
>
> ... and in "static int sdp2430_panel_enable(...)" this would
> seem to be wrong. But for that matter, lcd_2430sdp.c should
> not be relevant for any 3430 board anyway...
this was shared between two boards.
>
> If that file is, oddly, being shared between two boards ...
> then put that code in the "if (machine_is_omap_3430sdp())"
> block. And someone should consider renaming the file if
> it's not specific to the 2430 SDP.
OMAP3430_ES1 doesn't have this problem.
Stanley.
>
>
>
next prev parent reply other threads:[~2008-09-03 1:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 13:37 [PATCH] ARM: OMAP3: Fix omapfb's problem on OMAP3430sdp stanley.miao
2008-09-02 4:33 ` Gadiyar, Anand
2008-09-02 5:49 ` arun c
2008-09-02 6:13 ` stanley.miao
2008-09-02 8:14 ` Felipe Balbi
2008-09-02 9:33 ` stanley.miao
2008-09-05 17:13 ` Tony Lindgren
2008-09-08 2:27 ` stanley.miao
2008-09-02 14:51 ` David Brownell
2008-09-03 1:53 ` stanley.miao [this message]
2008-09-03 1:55 ` David Brownell
2008-09-03 3:40 ` stanley.miao
-- strict thread matches above, loose matches on Subject: below --
2008-09-08 2:42 stanley.miao
2008-09-08 3:29 ` stanley.miao
2008-09-10 17:46 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220406796.7042.34.camel@localhost \
--to=stanley.miao@windriver.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.