From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Kb20Y-00035h-GS for mharc-grub-devel@gnu.org; Wed, 03 Sep 2008 19:43:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kb20W-00033o-RS for grub-devel@gnu.org; Wed, 03 Sep 2008 19:43:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kb20T-0002zH-6b for grub-devel@gnu.org; Wed, 03 Sep 2008 19:43:28 -0400 Received: from [199.232.76.173] (port=34404 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kb20T-0002z7-1H for grub-devel@gnu.org; Wed, 03 Sep 2008 19:43:25 -0400 Received: from c60.cesmail.net ([216.154.195.49]:42964) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1Kb20S-0004kB-KM for grub-devel@gnu.org; Wed, 03 Sep 2008 19:43:24 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 03 Sep 2008 19:44:06 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 986484F1869 for ; Wed, 3 Sep 2008 19:43:23 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1220448464.4164.53.camel@fz.local> References: <1220448464.4164.53.camel@fz.local> Content-Type: text/plain Date: Wed, 03 Sep 2008 19:43:22 -0400 Message-Id: <1220485402.5868.8.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] update configure.ac to autoconf 2.61 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2008 23:43:29 -0000 On Wed, 2008-09-03 at 15:27 +0200, Felix Zielcke wrote: > Attached patch is generated via `autoupdate --force' from autoconf 2.61 > a svn-diff after ./autogen.sh doestn't show anything more, because > the ./configure script in SVN is already generated with autoconf 2.61. > > autoconf 2.61 is dated 17.11.2006 on ftp.gnu.org > > Debian etch + lenny have autoconf 2.61 > etch has been released 8th April 2007 > Ubuntu has it since feisty which has been released 19th April 2007 > > I haven't checked the others but I think this is recent enough for the > configure.ac (remember it's generated by ./autogen.sh anyway) > > Yes I really want to get rid of old stuff and if you even only need to > call `autoupdate --force' ;) I don't see any old stuff being removed. I don't see any justification for any of the changes. The new code is longer and less readable. I don't think AC_TRY_COMPILE is a big problem yet. It's not like it won't produce a valid test. In any case, please try to avoid extra long lines where it can be easily avoided. Okuji wrote that he uses Autoconf 2.59, so it would be nice to check that your changes would still work with that version. -- Regards, Pavel Roskin