From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KbKPW-0000Aq-GW for mharc-grub-devel@gnu.org; Thu, 04 Sep 2008 15:22:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KbKPU-00006Z-Hr for grub-devel@gnu.org; Thu, 04 Sep 2008 15:22:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KbKPS-0008Uj-Jh for grub-devel@gnu.org; Thu, 04 Sep 2008 15:22:27 -0400 Received: from [199.232.76.173] (port=45235 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KbKPR-0008UM-SE for grub-devel@gnu.org; Thu, 04 Sep 2008 15:22:26 -0400 Received: from moutng.kundenserver.de ([212.227.126.177]:51392) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KbKPR-0001nm-5m for grub-devel@gnu.org; Thu, 04 Sep 2008 15:22:25 -0400 Received: from [85.180.61.73] (e180061073.adsl.alicedsl.de [85.180.61.73]) by mrelayeu.kundenserver.de (node=mrelayeu7) with ESMTP (Nemesis) id 0ML2xA-1KbKPQ0EHe-0002li; Thu, 04 Sep 2008 21:22:24 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <1220520596.4167.24.camel@fz.local> References: <1220520596.4167.24.camel@fz.local> Content-Type: multipart/mixed; boundary="=-2cUI3eYo/BRrqr6OJQlV" Date: Thu, 04 Sep 2008 21:22:23 +0200 Message-Id: <1220556143.18782.46.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 X-Provags-ID: V01U2FsdGVkX18Ge+3maR2DYqg6tOo7hZ6Hq8bMom3LKqseGcS Xyq3J74Xh6gysoSFWfDqVwZO6UQf7YXiKF7IKdSgGxcjGnjPl9 SZNSx85+3QRMZQ/BjB8ZUzF/pfPqnfH X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) Subject: Re: floating point exception in disk/raid.c:206 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Sep 2008 19:22:28 -0000 --=-2cUI3eYo/BRrqr6OJQlV Content-Type: text/plain Content-Transfer-Encoding: 7bit Am Donnerstag, den 04.09.2008, 11:29 +0200 schrieb Felix Zielcke: > The easiest fix would be probable to just set chunk_size to for example > 64. > Attached patch does it, but maybe you have a better/other idea? Thanks to Bean on IRC. I think this is now the right place to do it, at end of insert_array in case of a new one. -- Felix Zielcke --=-2cUI3eYo/BRrqr6OJQlV Content-Disposition: attachment; filename=fpe.raid.diff.2 Content-Type: text/plain; name=fpe.raid.diff.2; charset=UTF-8 Content-Transfer-Encoding: 7bit 2008-09-04 Felix Zielcke * disk/raid.c (insert_array): Set `array->chunk_size' to 64 for RAID level 1. Index: disk/raid.c =================================================================== --- disk/raid.c (Revision 1850) +++ disk/raid.c (Arbeitskopie) @@ -575,6 +575,11 @@ insert_array (grub_disk_t disk, struct g /* Add our new array to the list. */ array->next = array_list; array_list = array; + + /* RAID 1 doestn't use a chunksize but code assumes one so set + one. */ + if (array->level == 1) + array->chunk_size = 64; } /* Add the device to the array. */ --=-2cUI3eYo/BRrqr6OJQlV--