From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, Simon Horman <horms@verge.net.au>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 3/3] ibm_newemac: MAL support for PowerPC 405EZ
Date: Fri, 05 Sep 2008 19:34:38 +1000 [thread overview]
Message-ID: <1220607278.4879.165.camel@pasglop> (raw)
In-Reply-To: <20080904234145.17f55cc2@zod.rchland.ibm.com>
> > > + if (of_device_is_compatible(ofdev->node, "ibm,mcmal-405ez"))
> > > + mal->features |= (MAL_FTR_CLEAR_ICINTSTAT | MAL_FTR_COMMON_ERR_INT);
> >
> > The above like is >80 characters wide.
> > But I'm not sure that anyone cares.
>
> I don't. If Ben complains I'll change it.
I wouldn't do a tatrum over it but if you're going to respin the
patch you may as well put the second constant on the next line.
Cheers,
Ben.
prev parent reply other threads:[~2008-09-05 9:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1220540078.git.jwboyer@linux.vnet.ibm.com>
2008-09-04 15:01 ` [PATCH 1/3] ibm_newemac: Allow the "no flow control" EMAC feature to work Josh Boyer
2008-09-04 15:02 ` [PATCH 2/3] ibm_newemac: Introduce mal_has_feature Josh Boyer
2008-09-05 3:19 ` Benjamin Herrenschmidt
2008-09-05 3:37 ` Josh Boyer
2008-09-04 15:02 ` [PATCH 3/3] ibm_newemac: MAL support for PowerPC 405EZ Josh Boyer
2008-09-05 2:10 ` Simon Horman
2008-09-05 2:10 ` Simon Horman
2008-09-05 3:41 ` Josh Boyer
2008-09-05 3:41 ` Josh Boyer
2008-09-05 9:34 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220607278.4879.165.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=horms@verge.net.au \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.