From: Peter Zijlstra <peterz@infradead.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@tglx.de,
torvalds@linux-foundation.org
Subject: Re: update on hrtimer based select/poll and range-hrtimers
Date: Sun, 07 Sep 2008 22:46:39 +0200 [thread overview]
Message-ID: <1220820399.8687.103.camel@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20080907111137.76a10b1e@infradead.org>
On Sun, 2008-09-07 at 11:11 -0700, Arjan van de Ven wrote:
> Hi,
>
> since the last lkml posting I've merged a few fixes and added comments
> from Peter, and I've redone the "estimate_accuracy" function.
>
> Rather than reposting the entire series, I'll point to the git tree at
>
> git://git.kernel.org/pub/scm/linux/kernel/git/arjan/linux-2.6-hrtimer.git
>
> and I've pasted the new function below.
> Rather than having the hardcoded steps from the "Linus" function, I've
> turned it into:
> 0 for realtime tasks
> "0.1% of the time" for not-nice, not realtime tasks
> "0.5% of the time" for nice, not realtime tasks
> with a cap of 100msec for both.
>
> I would like to request feedback on this approach; I think this is
> better than the "hardcoded steps" as before, but maybe someone can come
> up with an ever better idea....
logarithms pop to mind (again :-)
> static unsigned long __estimate_accuracy(struct timespec *tv)
> {
> unsigned long slack;
> int divfactor = 1000;
>
> if (task_nice(current))
This triggers for both -nice and +nice tasks, it might be worth
differentiating between those.
> divfactor = divfactor / 5;
>
> slack = tv->tv_nsec / divfactor;
> slack += tv->tv_sec * (NSEC_PER_SEC/divfactor);
>
> if (slack > 100 * NSEC_PER_MSEC)
> slack = 100 * NSEC_PER_MSEC;
> return slack;
> }
>
> static unsigned long estimate_accuracy(struct timespec *tv)
> {
> unsigned long ret;
> struct timespec now;
>
> /*
> * Realtime tasks get a slack of 0 for obvious reasons.
> */
>
> if (current->policy == SCHED_FIFO ||
> current->policy == SCHED_RR)
> return 0;
rt_task(current) ?
> ktime_get_ts(&now);
> now = timespec_sub(*tv, now);
> ret = __estimate_accuracy(&now);
> if (ret < current->timer_slack_ns)
> return current->timer_slack_ns;
pull out the max from __estimate_accuracy() and use clamp() here?
> return ret;
> }
next prev parent reply other threads:[~2008-09-07 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-07 18:11 update on hrtimer based select/poll and range-hrtimers Arjan van de Ven
2008-09-07 20:46 ` Peter Zijlstra [this message]
2008-09-07 21:07 ` Arjan van de Ven
2008-09-08 14:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220820399.8687.103.camel@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@tglx.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.