From: Phil Blundell <philb@gnu.org>
To: Claudio Scordino <claudio@evidence.eu.com>
Cc: "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>,
linux-mm@kvack.org
Subject: Re: Warning message when compiling ioremap.c
Date: Mon, 08 Sep 2008 14:19:28 +0100 [thread overview]
Message-ID: <1220879968.1250.1.camel@mill.internal.reciva.com> (raw)
In-Reply-To: <48C5247A.1030801@evidence.eu.com>
On Mon, 2008-09-08 at 15:11 +0200, Claudio Scordino wrote:
> The need for the goto exists only if BUG() can return, and it doesn't,
> so we can safely remove it as you suggested.
The structure of the original code (with the goto) is arranged so that
the code path is a straight line for the normal, non-bad case. If you
want to remove the goto, you should wrap the condition in unlikely() so
as not to introduce another branch.
> Who's in charge of maintaining this piece of code? Should the patch
> in attachment be submitted to some specific person?
I guess you should send it to the linux-arm-kernel list.
p.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-09-08 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 7:37 Warning message when compiling ioremap.c Claudio Scordino
2008-09-03 17:01 ` Luiz Fernando N. Capitulino
2008-09-08 13:11 ` Claudio Scordino
2008-09-08 13:19 ` Phil Blundell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220879968.1250.1.camel@mill.internal.reciva.com \
--to=philb@gnu.org \
--cc=claudio@evidence.eu.com \
--cc=lcapitulino@mandriva.com.br \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.