Re: [PATCH] pxa2xx_spi: wait_rx_stall before deasserting CS on PIO mode

[Daniel Ribeiro <drwyrm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Em Qui, 2008-09-11 às 10:41 -0700, David Brownell escreveu:
> You could instead
> 
>     return spi_write_then_read(pcap.spi, data, 4, data, 4);

Tried this already. data == 0x00000000.
Anyway, after the latest chipselect fixes, (deassert CS on
pump_transfer() || giveback() instead of int_transfer_complete()) the
code is working.

> to get the sequential (not concurrent!) I/O you need.  Be
> careful of byte ordering, of course; you probably should
> set spi->bits_per_word to 32 and then spi_setup(), as part
> of your driver init.

Yes, i guess i really should use spi_setup().
My current code is:

        spi_message_init(&m);
        t.len = 4;
        t.tx_buf = (u8 *)data;
        t.rx_buf = (u8 *)data;
        t.bits_per_word = 32;
        t.delay_usecs = 0;
        t.cs_change = 0;
        t.speed_hz = 13000000;
        spi_message_add_tail(&t, &m);
        return spi_sync(pcap.spi, &m);

I noted that if i dont set .delay_usecs it gets a default huge value,
same with .speed_hz, it dont use spi_board_info->max_speed_hz as
default. Would calling spi_setup() on my driver init solve this? Or is
this yet another issue?

Thanks for your reply.

--
Daniel Ribeiro



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general