From: David Woodhouse <dwmw2@infradead.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: Input pairing broken again
Date: Fri, 12 Sep 2008 19:52:53 -0700 [thread overview]
Message-ID: <1221274373.10249.25.camel@macbook.infradead.org> (raw)
In-Reply-To: <2d5a2c100809121946g4c485792i485b8771f9813823@mail.gmail.com>
On Fri, 2008-09-12 at 23:46 -0300, Luiz Augusto von Dentz wrote:
> Both seems good, but please use debug instead of printf. Btw does your
> first patch solves the problem?
Oops. I meant to remove the printf before I sent the patch :)
Have committed both to git://git.infradead.org/~dwmw2/bluez.git without
the printf.
Before my first patch, look closely at the handling of req->search_uuid
in browse_cb().
Note that it's incremented _every_ time we end up back in browse_cb().
Even when we've already finished going through the uuid_list[] array,
and we're supposed to be iterating through req->uuids.
So what happens is we handle everything in the uuid_list[] until we
reach the zero at the end. Then we handle the first item from
req->uuids, then we trawl through the memory _after_ uuid_list[],
treating it as more uuids to search for until we reach another zero.
Then we handle the second item from req->uuids, then...
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2008-09-13 2:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 0:21 Input pairing broken again David Woodhouse
2008-09-13 2:15 ` Luiz Augusto von Dentz
2008-09-13 2:17 ` David Woodhouse
2008-09-13 2:38 ` David Woodhouse
2008-09-13 2:46 ` Luiz Augusto von Dentz
2008-09-13 2:52 ` David Woodhouse [this message]
2008-09-13 2:57 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221274373.10249.25.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.